Fix BaseRenderingContext2D create/put/get-ImageData() for color managed canvas

third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h

Index: third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
index d629a0c6674f416b37a0ba5c48ff43df1b6bf737..08a419c1fef38a12915aed86d4903b112cf9878e 100644
--- a/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.h
@@ -8,6 +8,7 @@
 #include "bindings/modules/v8/CSSImageValueOrHTMLImageElementOrSVGImageElementOrHTMLVideoElementOrHTMLCanvasElementOrImageBitmapOrOffscreenCanvas.h"
 #include "bindings/modules/v8/StringOrCanvasGradientOrCanvasPattern.h"
 #include "core/html/ImageData.h"
+#include "core/html/canvas/CanvasRenderingContext.h"
 #include "modules/ModulesExport.h"
 #include "modules/canvas2d/CanvasGradient.h"
 #include "modules/canvas2d/CanvasPathMethods.h"
@@ -374,6 +375,14 @@ class MODULES_EXPORT BaseRenderingContext2D : public GarbageCollectedMixin,
 
   void clearCanvas();
   bool rectContainsTransformedRect(const FloatRect&, const SkIRect&) const;
+
+  virtual const CanvasRenderingContext* renderingContext() const {

[fserb, 2017/04/07 20:03:33]

talking to junov@ offline, I don't think we should do this.
The current inheritance situation is a bit messy, and we are thinking of ways to
solve this, but I think adding a renderingContext() here is going to make it
messier.

Could you please add the virtual methods you need (colorSpaceAsString() and
pixelFormat() with reasonable defaults) instead and implement them on the
*Context2D classes?

That way, we keep BaseRenderingContext2D independent of CanvasRenderingContext
and then, once we solve the bigger inheritance issue (i.e., having a proper base
class for Canvas and OffscreenCanvas), we can move it all there. 

+    return nullptr;
+  }
+
+  bool colorSettingsAsImageDataColorSettings(ImageDataColorSettings&) const;
+
+  bool m_isColorManaged;
 };
 
 template <typename DrawFunc, typename ContainsFunc>