Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl

Issue 2797213002: Fix BaseRenderingContext2D create/put/get-ImageData() for color managed canvas (Closed)
Patch Set: Fixing more interface listings fails Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
index 9fa38ca183503335b4b25d49e0ecb8d9e271c231..3ff6589523756ebdf84b24f512cc2f5e6c23f4f8 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl
@@ -129,6 +129,10 @@ enum ImageSmoothingQuality {"low", "medium", "high"};
[RaisesException] ImageData getImageData(long sx, long sy, long sw, long sh);
[RaisesException] void putImageData(ImageData imagedata, long dx, long dy);
[RaisesException] void putImageData(ImageData imagedata, long dx, long dy, long dirtyX, long dirtyY, long dirtyWidth, long dirtyHeight);
+
+ // https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] ImageData createImageData(unsigned long sw, unsigned long sh, ImageDataColorSettings imageDataColorSettings);
Justin Novosad 2017/04/11 21:28:05 imageDataColorSettings should be optional. I am o
zakerinasab 2017/04/15 07:04:42 This cannot be done now, as the call without Image
+ [RuntimeEnabled=ExperimentalCanvasFeatures, RaisesException] ImageData createImageData(ImageDataArray data, unsigned long sw, unsigned long sh, ImageDataColorSettings imageDataColorSettings);
Justin Novosad 2017/04/11 21:28:05 Same here.
zakerinasab 2017/04/15 07:04:42 Addressed in the same CL.
// Context state
// Should be merged with WebGL counterpart in CanvasRenderingContext, once no-longer experimental

Powered by Google App Engine
This is Rietveld 408576698