Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2797203002: 📰 Surface settings feature in chrome://flags (Closed)

Created:
3 years, 8 months ago by dgn
Modified:
3 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Suggestions] Surface settings feature in chrome://flags Also flips the feature to be disabled by default, but since it's available in the UI, it can be manually enabled back. BUG=706384 Review-Url: https://codereview.chromium.org/2797203002 Cr-Commit-Position: refs/heads/master@{#462514} Committed: https://chromium.googlesource.com/chromium/src/+/2b5a433872da47655e05d80d85b3f221cd6a9f29

Patch Set 1 #

Patch Set 2 : Add flags to logincustomflags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (20 generated)
dgn
PTAL
3 years, 8 months ago (2017-04-05 16:42:31 UTC) #3
Michael van Ouwerkerk
lgtm
3 years, 8 months ago (2017-04-05 16:47:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797203002/1
3 years, 8 months ago (2017-04-05 17:23:21 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/398864)
3 years, 8 months ago (2017-04-05 17:52:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797203002/1
3 years, 8 months ago (2017-04-06 09:04:36 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/266029)
3 years, 8 months ago (2017-04-06 10:20:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797203002/20001
3 years, 8 months ago (2017-04-06 15:20:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/404369)
3 years, 8 months ago (2017-04-06 15:27:54 UTC) #23
dgn
PTAL. I added a new flag that needs to be declared in histograms.xml
3 years, 8 months ago (2017-04-06 15:31:42 UTC) #25
Alexei Svitkine (slow)
lgtm
3 years, 8 months ago (2017-04-06 16:15:42 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2797203002/20001
3 years, 8 months ago (2017-04-06 16:44:09 UTC) #29
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 16:57:52 UTC) #32
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2b5a433872da47655e05d80d85b3...

Powered by Google App Engine
This is Rietveld 408576698