Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2797183002: CSP: Allow secure upgrade from an explicitly insecure expression. (Closed)

Created:
3 years, 8 months ago by arthursonzogni
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam, andypaicu
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CSP: Allow secure upgrade from an explicitly insecure expression. This CL is a suggestion on: https://codereview.chromium.org/2792013002/ --- Content-Security-Policy allows an url to match a source-expression even if the scheme or the port doesn't matches, but in this case it must be an upgrade to a more secure scheme(http->https) and more secure port(80->443). The problem is that it happens independently, so it is allowed to have an upgrade of the port without the scheme (http over 443) or an upgrade of the scheme without the port (https over 80). This is a change to force the upgrade to be both over port and scheme. --- BUG=692499, 692442

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -39 lines) Patch
M content/common/content_security_policy/csp_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/content_security_policy/csp_context.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M content/common/content_security_policy/csp_source.cc View 4 chunks +54 lines, -22 lines 0 comments Download
M content/common/content_security_policy/csp_source_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/content_security_policy/csp_source_unittest.cc View 6 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
andypaicu
3 years, 8 months ago (2017-04-06 09:07:10 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698