Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 2797173004: Remove use of Element in ResolutionEnqueuerListener. (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove use of Element in ResolutionEnqueuerListener. This makes ResolutionEnqueuerListener reusable for kernel-based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/7108d7b7a434449368a4388c939b8bfaa81ad385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -74 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +22 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 2 chunks +8 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 4 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 8 chunks +25 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 10 chunks +32 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 10 chunks +67 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-06 08:01:23 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-04-06 23:22:55 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-07 07:42:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7108d7b7a434449368a4388c939b8bfaa81ad385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698