Network traffic annotation added to gaia_cookie_manager_service.

components/signin/core/browser/gaia_cookie_manager_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/gaia_cookie_manager_service.h"
 
 #include <stddef.h>
 
 #include <queue>
 
 #include "base/format_macros.h"
 #include "base/json/json_reader.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/signin/core/browser/account_tracker_service.h"
 #include "components/signin/core/browser/signin_metrics.h"
 #include "google_apis/gaia/gaia_auth_fetcher.h"
 #include "google_apis/gaia/gaia_constants.h"
 #include "google_apis/gaia/gaia_urls.h"
 #include "google_apis/gaia/oauth2_token_service.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_delegate.h"
 
 namespace {
 
 // In case of an error while fetching using the GaiaAuthFetcher or URLFetcher,
 // retry with exponential backoff. Try up to 7 times within 15 minutes.
 const net::BackoffEntry::Policy kBackoffPolicy = {
     // Number of initial errors (in sequence) to ignore before applying
     // exponential back-off rules.
@@ skipping 168 matching lines @@
   // * The result of merging accounts to Gaia cookies will not be affected.
   // * Gaia will need make its own call about whether to check them itself,
   //   of make some other assumptions.
   CleanupTransientState();
   GetCheckConnectionInfoCompleted(false);
 }
 
 std::unique_ptr<net::URLFetcher>
 GaiaCookieManagerService::ExternalCcResultFetcher::CreateFetcher(
     const GURL& url) {
-  std::unique_ptr<net::URLFetcher> fetcher =
-      net::URLFetcher::Create(0, url, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation(
+          "gaia_cookie_manager_external_cc_result", R"(
+          semantics {
+            sender: "Gaia Cookie Manager"
+            description:
+              "This request is used by the GaiaCookieManager when adding an "
+              "account to the Gaia cookies to check the server connection "

[msramek, 2017/05/03 16:22:34]

I'm not sure "Gaia" is understandable to an external reader. Could we just say
Chrome/Google sign-in cookies or something such?

[msarda, 2017/05/09 08:35:42]

We already use GAIA/Gaia in a lot of places in Chrome:
https://cs.chromium.org/search/?q=Gaia+package:%5Echromium$&type=cs

[msramek, 2017/05/09 09:09:45]

Right, but we don't use it in HC articles or the privacy whitepaper. This text
is to be read by enterprise admins configuring Chrome.

I think it's fine to say "used by GaiaCookieManager" because, well, that's just
how the class is called. But when we're explaining what it does, we should use
terms that the reader will know.

[msarda, 2017/05/09 09:17:31]

I did not know this will be used in "HC" articles or privacy whitepaper. In that
case I agree we would need to be more careful about this text.
Ramin: Is that so? Where will this text be used?

Gaia is the Google authentication server. So I would change it to something like
"Google authentication cookies".

[Ramin Halavati, 2017/05/09 09:35:05]

Yes Mihai, as Martin mentioned, this data is also used for enterprise policy
assertions and help on how to set required limitations.

+              "state."

[msramek, 2017/05/03 16:22:34]

Optional: Why do we need to know the server connection state?

[msarda, 2017/05/09 08:35:42]

It looks like this is an optional request that allows Gaia to avoid doing some
server-side checks (see comment above on function
|OnGetCheckConnectionInfoError|). That is all I know unfortunately.

[Ramin Halavati, 2017/05/09 09:35:05]

Acknowledged.

+            trigger:
+              "This is used only once in the first merge session flow by the "
+              "GaiaCookieManager. The value of the first fetch is stored for "
+              "future uses."
+            data: "None."
+            destination: GOOGLE_OWNED_SERVICE
+          }
+          policy {
+            cookies_allowed: false
+            setting: "This feature cannot be disabled in settings."
+            policy_exception_justification:
+              "Not implemented. Disabling GaiaCookieManager would break "
+              "features that depend on it (like account consistency and "
+              "support for child accounts). It makes sense to control top "
+              "level features that use the GaiaCookieManager."
+          })");
+  std::unique_ptr<net::URLFetcher> fetcher = net::URLFetcher::Create(
+      0, url, net::URLFetcher::GET, this, traffic_annotation);
   fetcher->SetRequestContext(helper_->request_context());
   fetcher->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                         net::LOAD_DO_NOT_SAVE_COOKIES);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher.get(), data_use_measurement::DataUseUserData::SIGNIN);
 
   // Fetchers are sometimes cancelled because a network change was detected,
   // especially at startup and after sign-in on ChromeOS.
   fetcher->SetAutomaticallyRetryOnNetworkChanges(1);
   return fetcher;
@@ skipping 588 matching lines @@
         break;
       case GaiaCookieRequestType::LIST_ACCOUNTS:
         uber_token_fetcher_.reset();
         signin_client_->DelayNetworkCall(
             base::Bind(&GaiaCookieManagerService::StartFetchingListAccounts,
                        base::Unretained(this)));
         break;
     }
   }
 }