Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issue 2797133008: merge fasta.Keyword into analyzer.Keyword (Closed)

Created:
3 years, 8 months ago by danrubel
Modified:
3 years, 8 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -424 lines) Patch
M pkg/analysis_server/lib/src/services/refactoring/naming_conventions.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/token_utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/array_based_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/front_end/lib/src/fasta/scanner/keyword.dart View 1 chunk +0 lines, -315 lines 0 comments Download
A pkg/front_end/lib/src/fasta/scanner/keyword_state.dart View 1 chunk +148 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/token.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/scanner/token.dart View 2 chunks +65 lines, -64 lines 0 comments Download
M pkg/front_end/test/scanner_fasta_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/front_end/test/token_test.dart View 3 chunks +16 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 8 months ago (2017-04-06 19:35:09 UTC) #2
Paul Berry
lgtm
3 years, 8 months ago (2017-04-06 20:15:14 UTC) #3
danrubel
3 years, 8 months ago (2017-04-06 20:52:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
46b0c1da56bbf2aa79414212f698fb97c6433ed1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698