Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1196)

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2797073002: Move WebTextCheckClient reference from WebViewImpl to WebLocalFrameImpl (Closed)
Patch Set: Spell my name correctly Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
index d9b19a7c10009157b52de28a202a49664958e62b..bb6db0126cd8e54bab8f48ef305a3885a4b50160 100644
--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
@@ -6290,10 +6290,11 @@ TEST_P(ParameterizedWebFrameTest, ReplaceMisspelledRange) {
registerMockedHttpURLLoad("spell.html");
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
- TextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
+ TextCheckClient textcheck;
+ frame->setTextCheckClient(&textcheck);
+
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -6337,10 +6338,11 @@ TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkers) {
registerMockedHttpURLLoad("spell.html");
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
- TextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
+ TextCheckClient textcheck;
+ frame->setTextCheckClient(&textcheck);
+
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -6379,10 +6381,12 @@ TEST_P(ParameterizedWebFrameTest, RemoveSpellingMarkersUnderWords) {
registerMockedHttpURLLoad("spell.html");
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
+
+ WebLocalFrameImpl* webFrame = webViewHelper.webView()->mainFrameImpl();
TextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
+ webFrame->setTextCheckClient(&textcheck);
- LocalFrame* frame = webViewHelper.webView()->mainFrameImpl()->frame();
+ LocalFrame* frame = webFrame->frame();
Document* document = frame->document();
Element* element = document->getElementById("data");
@@ -6456,10 +6460,10 @@ TEST_P(ParameterizedWebFrameTest, SlowSpellcheckMarkerPosition) {
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
+ WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
StubbornTextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
+ frame->setTextCheckClient(&textcheck);
- WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -6497,9 +6501,10 @@ TEST_P(ParameterizedWebFrameTest, CancelSpellingRequestCrash) {
registerMockedHttpURLLoad("spell.html");
FrameTestHelpers::WebViewHelper webViewHelper;
webViewHelper.initializeAndLoad(m_baseURL + "spell.html");
- webViewHelper.webView()->setTextCheckClient(0);
WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
+ frame->setTextCheckClient(0);
+
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -6517,10 +6522,10 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultErasesMarkers) {
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
+ WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
StubbornTextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
+ frame->setTextCheckClient(&textcheck);
- WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
@@ -6557,10 +6562,10 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultsSavedInDocument) {
FrameTestHelpers::WebViewHelper webViewHelper;
initializeTextSelectionWebView(m_baseURL + "spell.html", &webViewHelper);
+ WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
StubbornTextCheckClient textcheck;
- webViewHelper.webView()->setTextCheckClient(&textcheck);
+ frame->setTextCheckClient(&textcheck);
- WebLocalFrameImpl* frame = webViewHelper.webView()->mainFrameImpl();
Document* document = frame->frame()->document();
Element* element = document->getElementById("data");
« no previous file with comments | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/public/web/WebLocalFrame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698