Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2797073002: Move WebTextCheckClient reference from WebViewImpl to WebLocalFrameImpl (Closed)
Patch Set: Tue Apr 4 20:53:35 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 void unmarkText() override; 173 void unmarkText() override;
174 bool hasMarkedText() const override; 174 bool hasMarkedText() const override;
175 WebRange markedRange() const override; 175 WebRange markedRange() const override;
176 bool firstRectForCharacterRange(unsigned location, 176 bool firstRectForCharacterRange(unsigned location,
177 unsigned length, 177 unsigned length,
178 WebRect&) const override; 178 WebRect&) const override;
179 size_t characterIndexForPoint(const WebPoint&) const override; 179 size_t characterIndexForPoint(const WebPoint&) const override;
180 bool executeCommand(const WebString&) override; 180 bool executeCommand(const WebString&) override;
181 bool executeCommand(const WebString&, const WebString& value) override; 181 bool executeCommand(const WebString&, const WebString& value) override;
182 bool isCommandEnabled(const WebString&) const override; 182 bool isCommandEnabled(const WebString&) const override;
183 void setTextCheckClient(WebTextCheckClient*) override;
183 void enableSpellChecking(bool) override; 184 void enableSpellChecking(bool) override;
184 bool isSpellCheckingEnabled() const override; 185 bool isSpellCheckingEnabled() const override;
185 void replaceMisspelledRange(const WebString&) override; 186 void replaceMisspelledRange(const WebString&) override;
186 void removeSpellingMarkers() override; 187 void removeSpellingMarkers() override;
187 bool hasSelection() const override; 188 bool hasSelection() const override;
188 WebRange selectionRange() const override; 189 WebRange selectionRange() const override;
189 WebString selectionAsText() const override; 190 WebString selectionAsText() const override;
190 WebString selectionAsMarkup() const override; 191 WebString selectionAsMarkup() const override;
191 bool selectWordAroundCaret() override; 192 bool selectWordAroundCaret() override;
192 void selectRange(const WebPoint& base, const WebPoint& extent) override; 193 void selectRange(const WebPoint& base, const WebPoint& extent) override;
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 } 397 }
397 SharedWorkerRepositoryClientImpl* sharedWorkerRepositoryClient() const { 398 SharedWorkerRepositoryClientImpl* sharedWorkerRepositoryClient() const {
398 return m_sharedWorkerRepositoryClient.get(); 399 return m_sharedWorkerRepositoryClient.get();
399 } 400 }
400 401
401 void setInputEventsTransformForEmulation(const IntSize&, float); 402 void setInputEventsTransformForEmulation(const IntSize&, float);
402 403
403 static void selectWordAroundPosition(LocalFrame*, VisiblePosition); 404 static void selectWordAroundPosition(LocalFrame*, VisiblePosition);
404 405
405 TextCheckerClient& textCheckerClient() const; 406 TextCheckerClient& textCheckerClient() const;
407 WebTextCheckClient* textCheckClient() const { return m_textCheckClient; }
406 408
407 TextFinder* textFinder() const; 409 TextFinder* textFinder() const;
408 // Returns the text finder object if it already exists. 410 // Returns the text finder object if it already exists.
409 // Otherwise creates it and then returns. 411 // Otherwise creates it and then returns.
410 TextFinder& ensureTextFinder(); 412 TextFinder& ensureTextFinder();
411 413
412 // Returns a hit-tested VisiblePosition for the given point 414 // Returns a hit-tested VisiblePosition for the given point
413 VisiblePosition visiblePositionForViewportPoint(const WebPoint&); 415 VisiblePosition visiblePositionForViewportPoint(const WebPoint&);
414 416
415 void setFrameWidget(WebFrameWidgetBase*); 417 void setFrameWidget(WebFrameWidgetBase*);
416 418
417 // DevTools front-end bindings. 419 // DevTools front-end bindings.
418 void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) { 420 void setDevToolsFrontend(WebDevToolsFrontendImpl* frontend) {
419 m_webDevToolsFrontend = frontend; 421 m_webDevToolsFrontend = frontend;
420 } 422 }
421 WebDevToolsFrontendImpl* devToolsFrontend() { return m_webDevToolsFrontend; } 423 WebDevToolsFrontendImpl* devToolsFrontend() { return m_webDevToolsFrontend; }
422 424
423 WebNode contextMenuNode() const { return m_contextMenuNode.get(); } 425 WebNode contextMenuNode() const { return m_contextMenuNode.get(); }
424 void setContextMenuNode(Node* node) { m_contextMenuNode = node; } 426 void setContextMenuNode(Node* node) { m_contextMenuNode = node; }
425 void clearContextMenuNode() { m_contextMenuNode.clear(); } 427 void clearContextMenuNode() { m_contextMenuNode.clear(); }
426 428
427
428 DECLARE_TRACE(); 429 DECLARE_TRACE();
429 430
430 private: 431 private:
431 friend class LocalFrameClientImpl; 432 friend class LocalFrameClientImpl;
432 433
433 WebLocalFrameImpl(WebTreeScopeType, 434 WebLocalFrameImpl(WebTreeScopeType,
434 WebFrameClient*, 435 WebFrameClient*,
435 blink::InterfaceProvider*, 436 blink::InterfaceProvider*,
436 blink::InterfaceRegistry*); 437 blink::InterfaceRegistry*);
437 WebLocalFrameImpl(WebRemoteFrame*, 438 WebLocalFrameImpl(WebRemoteFrame*,
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 // Borrowed pointers to Mojo objects. 495 // Borrowed pointers to Mojo objects.
495 blink::InterfaceProvider* m_interfaceProvider; 496 blink::InterfaceProvider* m_interfaceProvider;
496 blink::InterfaceRegistry* m_interfaceRegistry; 497 blink::InterfaceRegistry* m_interfaceRegistry;
497 498
498 WebDevToolsFrontendImpl* m_webDevToolsFrontend; 499 WebDevToolsFrontendImpl* m_webDevToolsFrontend;
499 500
500 Member<Node> m_contextMenuNode; 501 Member<Node> m_contextMenuNode;
501 502
502 std::unique_ptr<WebInputMethodControllerImpl> m_inputMethodController; 503 std::unique_ptr<WebInputMethodControllerImpl> m_inputMethodController;
503 504
504 // Stores the TextCheckerClient which communicates with SpellCheckProvider. 505 // Stores the TextCheckerClient to bridge SpellChecker and WebTextCheckClient.
505 Member<TextCheckerClientImpl> m_textCheckerClient; 506 Member<TextCheckerClientImpl> m_textCheckerClient;
507 WebTextCheckClient* m_textCheckClient;
506 508
507 // Oilpan: WebLocalFrameImpl must remain alive until close() is called. 509 // Oilpan: WebLocalFrameImpl must remain alive until close() is called.
508 // Accomplish that by keeping a self-referential Persistent<>. It is 510 // Accomplish that by keeping a self-referential Persistent<>. It is
509 // cleared upon close(). 511 // cleared upon close().
510 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive; 512 SelfKeepAlive<WebLocalFrameImpl> m_selfKeepAlive;
511 }; 513 };
512 514
513 DEFINE_TYPE_CASTS(WebLocalFrameImpl, 515 DEFINE_TYPE_CASTS(WebLocalFrameImpl,
514 WebFrame, 516 WebFrame,
515 frame, 517 frame,
516 frame->isWebLocalFrame(), 518 frame->isWebLocalFrame(),
517 frame.isWebLocalFrame()); 519 frame.isWebLocalFrame());
518 520
519 } // namespace blink 521 } // namespace blink
520 522
521 #endif 523 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698