Add a presubmit checker for duplicated enum values in UseCounter::Feature

third_party/WebKit/Source/core/frame/PRESUBMIT.py

Index: third_party/WebKit/Source/core/frame/PRESUBMIT.py
diff --git a/third_party/WebKit/Source/core/frame/PRESUBMIT.py b/third_party/WebKit/Source/core/frame/PRESUBMIT.py
index 589861be7649c971a0fcaa37eb7149f56e8d8e74..4d105e328fc03a94b751b30f0c66e27362aec11d 100644
--- a/third_party/WebKit/Source/core/frame/PRESUBMIT.py
+++ b/third_party/WebKit/Source/core/frame/PRESUBMIT.py
@@ -74,11 +74,17 @@ def _RunUmaHistogramChecks(input_api, output_api):
 
     START_MARKER = '^enum Feature : uint32_t {'
     END_MARKER = '^NumberOfFeatures'
-    if update_histogram_enum.HistogramNeedsUpdate(
-            histogram_enum_name='FeatureObserver',
-            source_enum_path=source_path,
-            start_marker=START_MARKER,
-            end_marker=END_MARKER):
+    should_update_histogram, duplicated_values = update_histogram_enum.HistogramNeedsUpdate(

[Ilya Sherman, 2017/04/13 01:12:49]

Should this wrap to 80-col?

+        histogram_enum_name='FeatureObserver',
+        source_enum_path=source_path,
+        start_marker=START_MARKER,
+        end_marker=END_MARKER)
+    if duplicated_values:
+        return [output_api.PresubmitPromptWarning(
+            'UseCounter::Feature has been updated and there exists duplicated '
+            'values between (%s) and (%s)' % duplicated_values,
+            items=[source_path])]
+    if should_update_histogram:
         return [output_api.PresubmitPromptWarning(
             'UseCounter::Feature has been updated and the UMA mapping needs to '
             'be regenerated. Please run update_use_counter_feature_enum.py in '