Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2797013002: [Offline pages] Update background loader to override the WebContentsObserver methods expected (Closed)
Patch Set: fix offliner tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index 90a5f96b57bc19ee75c53f7d43606b027da0bd47..078a032c36292a11e4621bbafdb028705260533c 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -201,14 +201,11 @@ bool BackgroundLoaderOffliner::HandleTimeout(const SavePageRequest& request) {
return false;
}
-void BackgroundLoaderOffliner::DocumentLoadedInFrame(
- content::RenderFrameHost* render_host) {
- // Inform snapshot controller if in main frame.
- if (!render_host->GetParent())
- snapshot_controller_->DocumentAvailableInMainFrame();
+void BackgroundLoaderOffliner::DocumentAvailableInMainFrame() {
+ snapshot_controller_->DocumentAvailableInMainFrame();
}
-void BackgroundLoaderOffliner::DidStopLoading() {
+void BackgroundLoaderOffliner::DocumentOnLoadCompletedInMainFrame() {
if (!pending_request_.get()) {
DVLOG(1) << "DidStopLoading called even though no pending request.";
return;

Powered by Google App Engine
This is Rietveld 408576698