Issue 2796993002: Rename dart::Genericity::kClass to dart::Genericity::kCurrentClass to avoid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2796993002: Rename dart::Genericity::kClass to dart::Genericity::kCurrentClass to avoid (Closed)

Created:
3 years, 8 months ago by regis

Modified:
3 years, 8 months ago

Reviewers:
bkonyi

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Rename dart::Genericity::kClass to dart::Genericity::kCurrentClass to avoid collision with dart::kernel::Tag::kClass. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/a08c95e0030167c10863d4f6f95de221910240a0

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

regis

On 2017/04/04 18:57:34, bkonyi wrote: > Thanks for sharing ;) LGTM You're welcome. Thanks!

3 years, 8 months ago (2017-04-04 19:07:33 UTC) #4

regis

3 years, 8 months ago (2017-04-04 19:09:04 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a08c95e0030167c10863d4f6f95de221910240a0 (presubmit successful).