Add --build-summary-only-unlinked flag, which makes the output summary be an unlinked summary inste…

Add --build-summary-only-unlinked flag, which makes the output summary be an unlinked summary instead of a linked one.

BUG=
R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/3e623d7df16e4f4935a4e0bae3d80140187d3422

[jakemac, 2017-04-04 16:35:31]

Description was changed from

==========
Add --build-summary-only-unlinked flag, which makes the output summary be an
unlinked summary instead of a linked one.

BUG=
==========

to

==========
Add --build-summary-only-unlinked flag, which makes the output summary be an
unlinked summary instead of a linked one.

BUG=
==========

[jakemac, 2017-04-04 16:35:32]

jakemac@google.com changed reviewers:
+ paulberry@google.com

[jakemac, 2017-04-04 16:44:46]

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
pkg/analyzer_cli/lib/src/build_mode.dart:374: * If the [UnlinkedUnit] needed to
be computed, it will also be added to the
I don't really like this behavior, but I don't see a good way around it right
now.

Longer term it seems like maybe the assembler should expose the existing map of
uri->UnlinkedUnit, or it should handle deduping things automatically?

[Paul Berry, 2017-04-04 18:30:30]

lgtm

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
pkg/analyzer_cli/lib/src/build_mode.dart:374: * If the [UnlinkedUnit] needed to
be computed, it will also be added to the
On 2017/04/04 16:44:46, jakemac wrote:
> I don't really like this behavior, but I don't see a good way around it right
> now.
> 
> Longer term it seems like maybe the assembler should expose the existing map
of
> uri->UnlinkedUnit, or it should handle deduping things automatically?

Actually what I would prefer is if we just computed all the unlinked summaries
up front and manually added them to uriToUnit; then this function would just
look up the computed summary and return it.

However it might not be that easy--the current implementation has a side effect
that if a file is present in an input package, it won't be re-summarized, even
if it is explicitly listed as an input.  IIRC, there are some people relying on
that functionality.

In any case, it's definitely something to address in a future CL :)

[jakemac, 2017-04-04 19:21:06]

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
File pkg/analyzer_cli/lib/src/build_mode.dart (right):

https://codereview.chromium.org/2796953002/diff/1/pkg/analyzer_cli/lib/src/bu...
pkg/analyzer_cli/lib/src/build_mode.dart:374: * If the [UnlinkedUnit] needed to
be computed, it will also be added to the
On 2017/04/04 18:30:30, Paul Berry wrote:
> On 2017/04/04 16:44:46, jakemac wrote:
> > I don't really like this behavior, but I don't see a good way around it
right
> > now.
> > 
> > Longer term it seems like maybe the assembler should expose the existing map
> of
> > uri->UnlinkedUnit, or it should handle deduping things automatically?
> 
> Actually what I would prefer is if we just computed all the unlinked summaries
> up front and manually added them to uriToUnit; then this function would just
> look up the computed summary and return it.
> 
> However it might not be that easy--the current implementation has a side
effect
> that if a file is present in an input package, it won't be re-summarized, even
> if it is explicitly listed as an input.  IIRC, there are some people relying
on
> that functionality.
> 
> In any case, it's definitely something to address in a future CL :)

Acknowledged.

[jakemac, 2017-04-04 19:22:31]

Description was changed from

==========
Add --build-summary-only-unlinked flag, which makes the output summary be an
unlinked summary instead of a linked one.

BUG=
==========

to

==========
Add --build-summary-only-unlinked flag, which makes the output summary be an
unlinked summary instead of a linked one.

BUG=
R=paulberry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3e623d7df16e4f4935a4e0bae3d80140187d3422
==========

[jakemac, 2017-04-04 19:22:33]

Committed patchset #1 (id:1) manually as
3e623d7df16e4f4935a4e0bae3d80140187d3422 (presubmit successful).