components/nacl/app/nacl_fork_delegates_linux.cc - Issue 279693002: Split NaCl SFI and non-SFI helpers into separate processes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/app/nacl_fork_delegates_linux.cc

Issue 279693002: Split NaCl SFI and non-SFI helpers into separate processes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Oops, forgot to "git add" new files Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "components/nacl/app/nacl_fork_delegates_linux.h"

	6

	7 #include "base/memory/scoped_vector.h"

	8 #include "components/nacl/zygote/nacl_fork_delegate_linux.h"

	9

	10 namespace nacl {

	11

	12 void AddNaClZygoteForkDelegates(
	Mark Seaborn 2014/05/10 00:10:40 I think this belongs in components/nacl/zygote/nac I think this belongs in components/nacl/zygote/nacl_fork_delegate_linux.cc. It runs in the zygote process, so it belongs in components/nacl/zygote/, and it may as well live in the existing file. (ZygoteStarting() gets called from RunZygote() inside content/.) mdempsky 2014/05/10 01:58:52 Done. Show quoted text On 2014/05/10 00:10:40, Mark Seaborn wrote: > I think this belongs in components/nacl/zygote/nacl_fork_delegate_linux.cc. > > It runs in the zygote process, so it belongs in components/nacl/zygote/, and it > may as well live in the existing file. (ZygoteStarting() gets called from > RunZygote() inside content/.) Done.
	13 ScopedVector<content::ZygoteForkDelegate>* delegates) {

	14 delegates->push_back(new NaClForkDelegate(false /* nonsfi_mode */));

	15 delegates->push_back(new NaClForkDelegate(true /* nonsfi_mode */));

	16 }

	17

	18 } // namespace nacl

OLD	NEW