components/nacl/common/nacl_nonsfi_util.h - Issue 279693002: Split NaCl SFI and non-SFI helpers into separate processes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/common/nacl_nonsfi_util.h

Issue 279693002: Split NaCl SFI and non-SFI helpers into separate processes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Refactor IsNonSFIModeEnabled() into nacl/common Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_NACL_COMMON_NACL_NONSFI_UTIL_H_

	6 #define COMPONENTS_NACL_COMMON_NACL_NONSFI_UTIL_H_

	7

	8 namespace nacl {

	9

	10 // Returns true if non-SFI mode can run for a given platform and if non-SFI
	Mark Seaborn 2014/05/12 22:49:26 Nit: maybe "current platform"? (Since "given" sug Nit: maybe "current platform"? (Since "given" suggests it's an argument.) mdempsky 2014/05/12 22:54:24 Done. Show quoted text On 2014/05/12 22:49:26, Mark Seaborn wrote: > Nit: maybe "current platform"? (Since "given" suggests it's an argument.) Done.
	11 // manifest entries are preferred. There can be other restrictions which

	12 // prevent a particular module from launching. See NaClProcessHost::Launch

	13 // which makes the final determination.

	14 bool IsNonSFIModeEnabled();

	15

	16 } // namespace nacl

	17

	18 #endif // COMPONENTS_NACL_COMMON_NACL_NONSFI_UTIL_H_

OLD	NEW