Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 2796873002: Sending autofill types for username fields in sign-in forms for improving username detection. (Closed)
Patch Set: Fix compilation error Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index 1cc924fbeefcce0f91c524245ffdfc81c5311645..0ad2261d268459037df09e440eb86b4fff015d44 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -24,6 +24,7 @@
#include "components/password_manager/core/browser/password_manager_driver.h"
#include "components/password_manager/core/browser/password_store.h"
+using autofill::FormData;
using autofill::FormStructure;
namespace password_manager {
@@ -440,6 +441,9 @@ class PasswordFormManager : public FormFetcher::Consumer {
// Send appropriate votes based on what is currently being saved.
void SendVotesOnSave();
+ // Send a vote for sign-in forms with autofill types for a username field.
+ void SendSignInVote(const FormData& form_data);
+
// Sets |user_action_| and records some metrics.
void SetUserAction(UserAction user_action);

Powered by Google App Engine
This is Rietveld 408576698