Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 279683002: Initialize ServiceWorkerContextCore with a message loop for the disk cache to use. (Closed)

Created:
6 years, 7 months ago by michaeln
Modified:
6 years, 7 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Initialize ServiceWorkerContextCore with a message loop for the disk cache to use. BUG=364318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269977

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : #

Messages

Total messages: 15 (0 generated)
michaeln
ptal
6 years, 7 months ago (2014-05-09 04:07:51 UTC) #1
nhiroki
lgtm
6 years, 7 months ago (2014-05-09 04:32:08 UTC) #2
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 7 months ago (2014-05-09 19:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/279683002/60001
6 years, 7 months ago (2014-05-09 19:31:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 00:00:18 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 00:13:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/25250)
6 years, 7 months ago (2014-05-10 00:13:29 UTC) #7
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 7 months ago (2014-05-10 00:21:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/279683002/80001
6 years, 7 months ago (2014-05-10 00:23:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-10 03:46:07 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-10 04:54:13 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/152771)
6 years, 7 months ago (2014-05-10 04:54:13 UTC) #12
michaeln
The CQ bit was checked by michaeln@chromium.org
6 years, 7 months ago (2014-05-12 22:31:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaeln@chromium.org/279683002/100001
6 years, 7 months ago (2014-05-12 22:32:44 UTC) #14
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 03:00:09 UTC) #15
Message was sent while issue was closed.
Change committed as 269977

Powered by Google App Engine
This is Rietveld 408576698