Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3090)

Unified Diff: chrome/browser/extensions/external_registry_loader_win.h

Issue 2796783002: [Ext Registry] Do not try to re-watch registry if we are already watching it. (Closed)
Patch Set: revert retrying + add assert Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/external_registry_loader_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/external_registry_loader_win.h
diff --git a/chrome/browser/extensions/external_registry_loader_win.h b/chrome/browser/extensions/external_registry_loader_win.h
index e14fb864adcbb1b492f8a47d5107241f8257da95..9b93cec1dbd54f6322450c5270efdc7b081f4fc7 100644
--- a/chrome/browser/extensions/external_registry_loader_win.h
+++ b/chrome/browser/extensions/external_registry_loader_win.h
@@ -14,22 +14,25 @@ namespace extensions {
class ExternalRegistryLoader : public ExternalLoader {
public:
- ExternalRegistryLoader() {}
+ ExternalRegistryLoader();
protected:
+ ~ExternalRegistryLoader() override {} // protected for unit test.
+
void StartLoading() override;
private:
friend class base::RefCountedThreadSafe<ExternalLoader>;
- ~ExternalRegistryLoader() override {}
-
std::unique_ptr<base::DictionaryValue> LoadPrefsOnFileThread();
void LoadOnFileThread();
void CompleteLoadAndStartWatchingRegistry();
void UpdatePrefsOnFileThread();
void OnRegistryKeyChanged(base::win::RegKey* key);
+ // Whether or not we attempted to observe registry.
+ bool attempted_watching_registry_;
+
base::win::RegKey hklm_key_;
base::win::RegKey hkcu_key_;
« no previous file with comments | « no previous file | chrome/browser/extensions/external_registry_loader_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698