[Devtools] Execution context in console shows product experiment

third_party/WebKit/Source/devtools/front_end/console_frame_product_lookup/ConsoleFrameProductLookup.js

Index: third_party/WebKit/Source/devtools/front_end/console_frame_product_lookup/ConsoleFrameProductLookup.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console_frame_product_lookup/ConsoleFrameProductLookup.js b/third_party/WebKit/Source/devtools/front_end/console_frame_product_lookup/ConsoleFrameProductLookup.js
new file mode 100644
index 0000000000000000000000000000000000000000..5d3f469a65b80e7829648a8de00591f1479cb5b6
--- /dev/null
+++ b/third_party/WebKit/Source/devtools/front_end/console_frame_product_lookup/ConsoleFrameProductLookup.js
@@ -0,0 +1,48 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+/**
+ * @implements {Console.ConsoleFrameNameLookupInterface}
+ */
+ConsoleFrameProductLookup.ProductLookup = class {
+  /**
+   * @override
+   * @param {!SDK.ResourceTreeFrame} frame
+   * @return {?string}
+   */
+  nameForFrame(frame) {
+    var name;
+    var frameParsedURL = new Common.ParsedURL(frame.url);

[luoe, 2017/04/04 18:31:02]

nit, can we move this inside the 'if' block, same as L38?

[pfeldman, 2017/04/04 19:03:16]

+1. also, we seem to not be saving much via passing parsed URL into the
registry. Maybe pass a string there? Also enables better caching.

[allada, 2017/04/05 01:49:46]

Done.

[allada, 2017/04/05 01:49:46]

I wanted to keep it using a url because right now we only use domain out of it,
but we do have some data we might be able to use to be more specific with url
pattern matching.

Also, the primary user of the ProductRegistry are SDK.NetworkRequest's.
SDK.NetworkRequests have a parsedURL stored inside.

+    if (frame.url)
+      name = ProductRegistry.nameForUrl(frameParsedURL);
+    if (name)
+      return name;
+    // We are not caching the frame url result because it may change.

[pfeldman, 2017/04/04 19:03:16]

What does this mean?

[allada, 2017/04/05 01:49:46]

The frame's URL may change, but the creator of the frame never changes. So we
can cache the stuff below because it's only the "who created you" not the "who
are you" which is the code above. the "who are you" can be changed if the frame
gets navigated.

+    var symbol = ConsoleFrameProductLookup.ProductLookup._consoleProductFrameNameSymbol;
+    if (symbol in frame)
+      return frame[symbol];
+    frame[symbol] = this._lookupFrameStacktraceName(frame);
+    return frame[symbol];
+  }
+
+  /**
+   * @param {!SDK.ResourceTreeFrame} frame
+   * @return {?string}
+   */
+  _lookupFrameStacktraceName(frame) {

[pfeldman, 2017/04/04 19:03:16]

Looks like static method.

[allada, 2017/04/05 01:49:46]

Done.

+    var stackTrace = frame.creationStackTrace();
+    var name;
+    while (stackTrace) {

[caseq, 2017/04/04 18:59:40]

nit: consider for instead of while.

[allada, 2017/04/05 01:49:46]

Done.

+      for (var stack of stackTrace.callFrames) {

[luoe, 2017/04/04 18:31:02]

Can we rename 'stack' to 'callFrame' here?

[allada, 2017/04/05 01:49:45]

Done.

+        if (stack.url)
+          name = ProductRegistry.nameForUrl(new Common.ParsedURL(stack.url));
+        if (name)
+          return name;
+      }
+      stackTrace = frame.parent;

[caseq, 2017/04/04 18:59:40]

frame.parent does not exist. Also, what type do you expect it to be?

[allada, 2017/04/05 01:49:45]

Sorry, I meant stackTrace.parent. Fixed. It should be a
{?Protocol.Runtime.StackTrace}.

+    }
+    return null;
+  }
+};
+
+ConsoleFrameProductLookup.ProductLookup._consoleProductFrameNameSymbol = Symbol('ConsoleProductFrameName');