Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3022)

Unified Diff: chrome/renderer/searchbox/searchbox.cc

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox.cc
diff --git a/chrome/renderer/searchbox/searchbox.cc b/chrome/renderer/searchbox/searchbox.cc
index 186fd0277f66b1441a478f88fae189087c4e72df..aefd7f8e35d681518d09ee9d69ef4908b00875c9 100644
--- a/chrome/renderer/searchbox/searchbox.cc
+++ b/chrome/renderer/searchbox/searchbox.cc
@@ -267,15 +267,17 @@ void SearchBox::LogEvent(NTPLoggingEventType event) {
}
void SearchBox::LogMostVisitedImpression(int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
instant_service_->LogMostVisitedImpression(page_seq_no_, position,
- tile_source);
+ tile_source, tile_type);
}
void SearchBox::LogMostVisitedNavigation(int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
instant_service_->LogMostVisitedNavigation(page_seq_no_, position,
- tile_source);
+ tile_source, tile_type);
}
void SearchBox::CheckIsUserSignedInToChromeAs(const base::string16& identity) {

Powered by Google App Engine
This is Rietveld 408576698