Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: chrome/common/instant.mojom

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/instant.mojom
diff --git a/chrome/common/instant.mojom b/chrome/common/instant.mojom
index 581a8b5cc97e4f02cbf0a8d24ab5c7bbcc1d7c28..45c9da14459ae37605360fd02687ab4b90fb7b83 100644
--- a/chrome/common/instant.mojom
+++ b/chrome/common/instant.mojom
@@ -17,6 +17,9 @@ enum OmniboxFocusState;
[Native]
enum TileSource;
+[Native]
+enum TileVisualType;
+
// Interface used to connect to the embedded search interface. This is a
// separate interface such that a reverse connection (|client| below) can be
// passed when connecting.
@@ -57,12 +60,14 @@ interface Instant {
// Logs an impression on one of the Most Visited tile on the InstantExtended
// New Tab Page.
LogMostVisitedImpression(int32 page_seq_no, int32 position,
- TileSource tile_source);
+ TileSource tile_source,
+ TileVisualType tile_type);
// Logs a navigation on one of the Most Visited tile on the InstantExtended
// New Tab Page.
LogMostVisitedNavigation(int32 page_seq_no, int32 position,
- TileSource tile_source);
+ TileSource tile_source,
+ TileVisualType tile_type);
// Tells InstantExtended to paste text into the omnibox. If text is empty,
// the clipboard contents will be pasted. This causes the omnibox dropdown to

Powered by Google App Engine
This is Rietveld 408576698