Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
index 0e1ecd6cd290bba5e38e09dac602be28f87d3760..7b6fa35351391241fc45963c43b52fd0644a0bcf 100644
--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
@@ -14,6 +14,7 @@
#include "base/time/time.h"
#include "chrome/common/search/ntp_logging_events.h"
#include "components/ntp_tiles/tile_source.h"
+#include "components/ntp_tiles/tile_visual_type.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
@@ -41,11 +42,13 @@ class NTPUserDataLogger
// Logs an impression on one of the NTP tiles by a given source.
void LogMostVisitedImpression(int position,
- ntp_tiles::TileSource tile_source);
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type);
// Logs a navigation on one of the NTP tiles by a given source.
void LogMostVisitedNavigation(int position,
- ntp_tiles::TileSource tile_source);
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type);
protected:
explicit NTPUserDataLogger(content::WebContents* contents);
@@ -86,6 +89,10 @@ class NTPUserDataLogger
// corresponding entry in |impression_was_logged_| is true.
std::vector<ntp_tiles::TileSource> impression_tile_source_;
+ // Stores the tile type for each impression. Entries are only valid if the
+ // corresponding entry in |impression_was_logged_| is true.
+ std::vector<ntp_tiles::TileVisualType> impression_tile_type_;
+
// The time we received the NTP_ALL_TILES_RECEIVED event.
base::TimeDelta tiles_received_time_;

Powered by Google App Engine
This is Rietveld 408576698