Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8109)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index ca18125a42ec3c3128c30e84204623de558ea7bd..1037cb53896c88ebb25647f967c9aedefb386afb 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -405,21 +405,23 @@ void SearchTabHelper::OnLogEvent(NTPLoggingEventType event,
void SearchTabHelper::OnLogMostVisitedImpression(
int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
// TODO(kmadhusu): Move platform specific code from here and get rid of #ifdef.
#if !defined(OS_ANDROID)
- NTPUserDataLogger::GetOrCreateFromWebContents(
- web_contents())->LogMostVisitedImpression(position, tile_source);
+ NTPUserDataLogger::GetOrCreateFromWebContents(web_contents())
+ ->LogMostVisitedImpression(position, tile_source, tile_type);
#endif
}
void SearchTabHelper::OnLogMostVisitedNavigation(
int position,
- ntp_tiles::TileSource tile_source) {
+ ntp_tiles::TileSource tile_source,
+ ntp_tiles::TileVisualType tile_type) {
// TODO(kmadhusu): Move platform specific code from here and get rid of #ifdef.
#if !defined(OS_ANDROID)
- NTPUserDataLogger::GetOrCreateFromWebContents(
- web_contents())->LogMostVisitedNavigation(position, tile_source);
+ NTPUserDataLogger::GetOrCreateFromWebContents(web_contents())
+ ->LogMostVisitedNavigation(position, tile_source, tile_type);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698