Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: components/ntp_tiles/tile_visual_type.h

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_ 5 #ifndef COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
6 #define COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_ 6 #define COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
7 7
8 namespace ntp_tiles { 8 namespace ntp_tiles {
9 9
10 // The visual type of an NTP tile. 10 // The visual type of an NTP tile.
11 // 11 //
12 // These values must stay in sync with the NTPTileVisualType enum in 12 // These values must stay in sync with the NTPTileVisualType enum in
13 // histograms.xml. 13 // histograms.xml.
14 // 14 //
15 // A Java counterpart will be generated for this enum. 15 // A Java counterpart will be generated for this enum.
16 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.suggestions 16 // GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.suggestions
17 enum TileVisualType { 17 enum TileVisualType {
18 // The icon or thumbnail hasn't loaded yet. 18 // The icon or thumbnail hasn't loaded yet.
19 NONE = 0, 19 NONE = 0,
20 // The item displays a site's actual favicon or touch icon. 20 // The item displays a site's actual favicon or touch icon.
21 ICON_REAL = 1, 21 ICON_REAL = 1,
22 // The item displays a color derived from the site's favicon or touch icon. 22 // The item displays a color derived from the site's favicon or touch icon.
23 ICON_COLOR = 2, 23 ICON_COLOR = 2,
24 // The item displays a default gray box in place of an icon. 24 // The item displays a default gray box in place of an icon.
25 ICON_DEFAULT = 3, 25 ICON_DEFAULT = 3,
26 // The number of different tile types that get recorded. Entries below this
27 // are not recorded in UMA.
28 NUM_RECORDED_TILE_TYPES,
29
30 // Deleted: THUMBNAIL_LOCAL = 4 26 // Deleted: THUMBNAIL_LOCAL = 4
31 // Deleted: THUMBNAIL_SERVER = 5 27 // Deleted: THUMBNAIL_SERVER = 5
32 // Deleted: THUMBNAIL_DEFAULT = 6 28 // Deleted: THUMBNAIL_DEFAULT = 6
29 // The item displays a thumbnail of the page. Used on desktop.
30 THUMBNAIL = 7,
31 // The item wants to display a thumbnail of the page, but it failed to load.
32 // Used on desktop.
33 THUMBNAIL_FAILED = 8,
34 // The maximum tile type value that gets recorded in UMA.
35 LAST_RECORDED_TILE_TYPE = THUMBNAIL_FAILED,
33 36
34 // The item displays a thumbnail of the page. Used on desktop.
35 THUMBNAIL,
36 // The tile type has not been determined yet. Used on iOS, until we can detect 37 // The tile type has not been determined yet. Used on iOS, until we can detect
37 // when all tiles have loaded. 38 // when all tiles have loaded.
38 UNKNOWN_TILE_TYPE, 39 UNKNOWN_TILE_TYPE,
40
41 TILE_TYPE_MAX = UNKNOWN_TILE_TYPE
39 }; 42 };
40 43
41 } // namespace ntp_tiles 44 } // namespace ntp_tiles
42 45
43 #endif // COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_ 46 #endif // COMPONENTS_NTP_TILES_TILE_VISUAL_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698