Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/common/instant.mojom

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module chrome.mojom; 5 module chrome.mojom;
6 6
7 import "mojo/common/string16.mojom"; 7 import "mojo/common/string16.mojom";
8 import "mojo/common/time.mojom"; 8 import "mojo/common/time.mojom";
9 import "url/mojo/url.mojom"; 9 import "url/mojo/url.mojom";
10 10
11 [Native] 11 [Native]
12 enum NTPLoggingEventType; 12 enum NTPLoggingEventType;
13 13
14 [Native] 14 [Native]
15 enum OmniboxFocusState; 15 enum OmniboxFocusState;
16 16
17 [Native] 17 [Native]
18 enum TileSource; 18 enum TileSource;
19 19
20 [Native]
21 enum TileVisualType;
22
20 // Interface used to connect to the embedded search interface. This is a 23 // Interface used to connect to the embedded search interface. This is a
21 // separate interface such that a reverse connection (|client| below) can be 24 // separate interface such that a reverse connection (|client| below) can be
22 // passed when connecting. 25 // passed when connecting.
23 interface EmbeddedSearchConnector { 26 interface EmbeddedSearchConnector {
24 // Connect to the interface. |instant| is the connection which the client will 27 // Connect to the interface. |instant| is the connection which the client will
25 // use to query the embedded search interface. |client| is the connection used 28 // use to query the embedded search interface. |client| is the connection used
26 // by the embedded search interface implementation to push browser state 29 // by the embedded search interface implementation to push browser state
27 // updates to the client. 30 // updates to the client.
28 Connect(associated Instant& instant, associated SearchBox client); 31 Connect(associated Instant& instant, associated SearchBox client);
29 }; 32 };
(...skipping 20 matching lines...) Expand all
50 UndoMostVisitedDeletion(int32 page_seq_no, url.mojom.Url url); 53 UndoMostVisitedDeletion(int32 page_seq_no, url.mojom.Url url);
51 54
52 // Logs events from InstantExtended New Tab Pages. 55 // Logs events from InstantExtended New Tab Pages.
53 LogEvent(int32 page_seq_no, 56 LogEvent(int32 page_seq_no,
54 NTPLoggingEventType event, 57 NTPLoggingEventType event,
55 mojo.common.mojom.TimeDelta time); 58 mojo.common.mojom.TimeDelta time);
56 59
57 // Logs an impression on one of the Most Visited tile on the InstantExtended 60 // Logs an impression on one of the Most Visited tile on the InstantExtended
58 // New Tab Page. 61 // New Tab Page.
59 LogMostVisitedImpression(int32 page_seq_no, int32 position, 62 LogMostVisitedImpression(int32 page_seq_no, int32 position,
60 TileSource tile_source); 63 TileSource tile_source,
64 TileVisualType tile_type);
61 65
62 // Logs a navigation on one of the Most Visited tile on the InstantExtended 66 // Logs a navigation on one of the Most Visited tile on the InstantExtended
63 // New Tab Page. 67 // New Tab Page.
64 LogMostVisitedNavigation(int32 page_seq_no, int32 position, 68 LogMostVisitedNavigation(int32 page_seq_no, int32 position,
65 TileSource tile_source); 69 TileSource tile_source,
70 TileVisualType tile_type);
66 71
67 // Tells InstantExtended to paste text into the omnibox. If text is empty, 72 // Tells InstantExtended to paste text into the omnibox. If text is empty,
68 // the clipboard contents will be pasted. This causes the omnibox dropdown to 73 // the clipboard contents will be pasted. This causes the omnibox dropdown to
69 // open. 74 // open.
70 PasteAndOpenDropdown(int32 page_seq_no, 75 PasteAndOpenDropdown(int32 page_seq_no,
71 mojo.common.mojom.String16 text_to_be_pasted); 76 mojo.common.mojom.String16 text_to_be_pasted);
72 77
73 // The Instant page asks whether the user syncs its history. 78 // The Instant page asks whether the user syncs its history.
74 HistorySyncCheck(int32 page_seq_no); 79 HistorySyncCheck(int32 page_seq_no);
75 80
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 120
116 ThemeChanged(ThemeBackgroundInfo value); 121 ThemeChanged(ThemeBackgroundInfo value);
117 122
118 // TODO(treib): Remove the *Result methods and instead add return values to 123 // TODO(treib): Remove the *Result methods and instead add return values to
119 // the correspnding methods in the Instant interface above. 124 // the correspnding methods in the Instant interface above.
120 HistorySyncCheckResult(bool sync_history); 125 HistorySyncCheckResult(bool sync_history);
121 126
122 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity, 127 ChromeIdentityCheckResult(mojo.common.mojom.String16 identity,
123 bool identity_match); 128 bool identity_match);
124 }; 129 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698