Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: chrome/browser/ui/search/search_tab_helper_unittest.cc

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/search/search_tab_helper.h" 5 #include "chrome/browser/ui/search/search_tab_helper.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <string> 10 #include <string>
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 virtual ~MockSearchIPCRouterDelegate() {} 53 virtual ~MockSearchIPCRouterDelegate() {}
54 54
55 MOCK_METHOD1(OnInstantSupportDetermined, void(bool supports_instant)); 55 MOCK_METHOD1(OnInstantSupportDetermined, void(bool supports_instant));
56 MOCK_METHOD1(FocusOmnibox, void(OmniboxFocusState state)); 56 MOCK_METHOD1(FocusOmnibox, void(OmniboxFocusState state));
57 MOCK_METHOD2(NavigateToURL, void(const GURL&, WindowOpenDisposition)); 57 MOCK_METHOD2(NavigateToURL, void(const GURL&, WindowOpenDisposition));
58 MOCK_METHOD1(OnDeleteMostVisitedItem, void(const GURL& url)); 58 MOCK_METHOD1(OnDeleteMostVisitedItem, void(const GURL& url));
59 MOCK_METHOD1(OnUndoMostVisitedDeletion, void(const GURL& url)); 59 MOCK_METHOD1(OnUndoMostVisitedDeletion, void(const GURL& url));
60 MOCK_METHOD0(OnUndoAllMostVisitedDeletions, void()); 60 MOCK_METHOD0(OnUndoAllMostVisitedDeletions, void());
61 MOCK_METHOD2(OnLogEvent, void(NTPLoggingEventType event, 61 MOCK_METHOD2(OnLogEvent, void(NTPLoggingEventType event,
62 base::TimeDelta time)); 62 base::TimeDelta time));
63 MOCK_METHOD2(OnLogMostVisitedImpression, 63 MOCK_METHOD3(OnLogMostVisitedImpression,
64 void(int position, ntp_tiles::TileSource tile_source)); 64 void(int position,
65 MOCK_METHOD2(OnLogMostVisitedNavigation, 65 ntp_tiles::TileSource tile_source,
66 void(int position, ntp_tiles::TileSource tile_source)); 66 ntp_tiles::TileVisualType tile_type));
67 MOCK_METHOD3(OnLogMostVisitedNavigation,
68 void(int position,
69 ntp_tiles::TileSource tile_source,
70 ntp_tiles::TileVisualType tile_type));
67 MOCK_METHOD1(PasteIntoOmnibox, void(const base::string16&)); 71 MOCK_METHOD1(PasteIntoOmnibox, void(const base::string16&));
68 MOCK_METHOD1(OnChromeIdentityCheck, void(const base::string16& identity)); 72 MOCK_METHOD1(OnChromeIdentityCheck, void(const base::string16& identity));
69 MOCK_METHOD0(OnHistorySyncCheck, void()); 73 MOCK_METHOD0(OnHistorySyncCheck, void());
70 }; 74 };
71 75
72 class MockSearchBoxClientFactory 76 class MockSearchBoxClientFactory
73 : public SearchIPCRouter::SearchBoxClientFactory { 77 : public SearchIPCRouter::SearchBoxClientFactory {
74 public: 78 public:
75 MOCK_METHOD0(GetSearchBox, chrome::mojom::SearchBox*(void)); 79 MOCK_METHOD0(GetSearchBox, chrome::mojom::SearchBox*(void));
76 }; 80 };
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
298 }; 302 };
299 303
300 TEST_F(SearchTabHelperTest, TitleIsSetForNTP) { 304 TEST_F(SearchTabHelperTest, TitleIsSetForNTP) {
301 TabTitleObserver title_observer(web_contents()); 305 TabTitleObserver title_observer(web_contents());
302 NavigateAndCommit(GURL(chrome::kChromeUINewTabURL)); 306 NavigateAndCommit(GURL(chrome::kChromeUINewTabURL));
303 const base::string16 title = l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE); 307 const base::string16 title = l10n_util::GetStringUTF16(IDS_NEW_TAB_TITLE);
304 EXPECT_EQ(title, title_observer.title_on_start()); 308 EXPECT_EQ(title, title_observer.title_on_start());
305 EXPECT_EQ(title, title_observer.title_on_commit()); 309 EXPECT_EQ(title, title_observer.title_on_commit());
306 EXPECT_EQ(title, web_contents()->GetTitle()); 310 EXPECT_EQ(title, web_contents()->GetTitle());
307 } 311 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698