Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 2796643002: NTP: Record TileType metrics also on desktop (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 6 #define CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "chrome/browser/search/instant_service_observer.h" 14 #include "chrome/browser/search/instant_service_observer.h"
15 #include "chrome/browser/ui/search/search_ipc_router.h" 15 #include "chrome/browser/ui/search/search_ipc_router.h"
16 #include "chrome/browser/ui/search/search_model.h" 16 #include "chrome/browser/ui/search/search_model.h"
17 #include "chrome/common/search/instant_types.h" 17 #include "chrome/common/search/instant_types.h"
18 #include "chrome/common/search/ntp_logging_events.h" 18 #include "chrome/common/search/ntp_logging_events.h"
19 #include "components/ntp_tiles/tile_source.h" 19 #include "components/ntp_tiles/tile_source.h"
20 #include "components/ntp_tiles/tile_visual_type.h"
20 #include "components/omnibox/common/omnibox_focus_state.h" 21 #include "components/omnibox/common/omnibox_focus_state.h"
21 #include "content/public/browser/reload_type.h" 22 #include "content/public/browser/reload_type.h"
22 #include "content/public/browser/web_contents_observer.h" 23 #include "content/public/browser/web_contents_observer.h"
23 #include "content/public/browser/web_contents_user_data.h" 24 #include "content/public/browser/web_contents_user_data.h"
24 25
25 namespace content { 26 namespace content {
26 class WebContents; 27 class WebContents;
27 struct LoadCommittedDetails; 28 struct LoadCommittedDetails;
28 } 29 }
29 30
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 const content::LoadCommittedDetails& load_details) override; 134 const content::LoadCommittedDetails& load_details) override;
134 135
135 // Overridden from SearchIPCRouter::Delegate: 136 // Overridden from SearchIPCRouter::Delegate:
136 void OnInstantSupportDetermined(bool supports_instant) override; 137 void OnInstantSupportDetermined(bool supports_instant) override;
137 void FocusOmnibox(OmniboxFocusState state) override; 138 void FocusOmnibox(OmniboxFocusState state) override;
138 void OnDeleteMostVisitedItem(const GURL& url) override; 139 void OnDeleteMostVisitedItem(const GURL& url) override;
139 void OnUndoMostVisitedDeletion(const GURL& url) override; 140 void OnUndoMostVisitedDeletion(const GURL& url) override;
140 void OnUndoAllMostVisitedDeletions() override; 141 void OnUndoAllMostVisitedDeletions() override;
141 void OnLogEvent(NTPLoggingEventType event, base::TimeDelta time) override; 142 void OnLogEvent(NTPLoggingEventType event, base::TimeDelta time) override;
142 void OnLogMostVisitedImpression(int position, 143 void OnLogMostVisitedImpression(int position,
143 ntp_tiles::TileSource tile_source) override; 144 ntp_tiles::TileSource tile_source,
145 ntp_tiles::TileVisualType tile_type) override;
144 void OnLogMostVisitedNavigation(int position, 146 void OnLogMostVisitedNavigation(int position,
145 ntp_tiles::TileSource tile_source) override; 147 ntp_tiles::TileSource tile_source,
148 ntp_tiles::TileVisualType tile_type) override;
146 void PasteIntoOmnibox(const base::string16& text) override; 149 void PasteIntoOmnibox(const base::string16& text) override;
147 void OnChromeIdentityCheck(const base::string16& identity) override; 150 void OnChromeIdentityCheck(const base::string16& identity) override;
148 void OnHistorySyncCheck() override; 151 void OnHistorySyncCheck() override;
149 152
150 // Overridden from InstantServiceObserver: 153 // Overridden from InstantServiceObserver:
151 void ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) override; 154 void ThemeInfoChanged(const ThemeBackgroundInfo& theme_info) override;
152 void MostVisitedItemsChanged( 155 void MostVisitedItemsChanged(
153 const std::vector<InstantMostVisitedItem>& items) override; 156 const std::vector<InstantMostVisitedItem>& items) override;
154 157
155 // Invoked to update the instant support state. 158 // Invoked to update the instant support state.
(...skipping 26 matching lines...) Expand all
182 content::WebContents* web_contents_; 185 content::WebContents* web_contents_;
183 186
184 SearchIPCRouter ipc_router_; 187 SearchIPCRouter ipc_router_;
185 188
186 InstantService* instant_service_; 189 InstantService* instant_service_;
187 190
188 DISALLOW_COPY_AND_ASSIGN(SearchTabHelper); 191 DISALLOW_COPY_AND_ASSIGN(SearchTabHelper);
189 }; 192 };
190 193
191 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_ 194 #endif // CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698