third_party/WebKit/Source/core/streams/ReadableStream.js - Issue 2796633002: Add "mark promise as handled" change to pipeThrough()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/streams/ReadableStream.js

Issue 2796633002: Add "mark promise as handled" change to pipeThrough() (Closed)

Patch Set: Use v8.isPromise instead of instanceof Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/streams/ReadableStream.js

diff --git a/third_party/WebKit/Source/core/streams/ReadableStream.js b/third_party/WebKit/Source/core/streams/ReadableStream.js

index 02f1dbaf73f014e0c6f412460466809e181038be..ba4a6b13ca406a4c704e11ce61d0e9515461d577 100644

--- a/third_party/WebKit/Source/core/streams/ReadableStream.js

+++ b/third_party/WebKit/Source/core/streams/ReadableStream.js

@@ -177,7 +177,10 @@

}

pipeThrough({writable, readable}, options) {

- this.pipeTo(writable, options);

+ const promise = this.pipeTo(writable, options);

+ if (v8.isPromise(promise)) {

+ v8.markPromiseAsHandled(promise);

+ }

return readable;

}