OOPIF: Enable TabAndMouseFocusNavigation.

chrome/browser/site_per_process_interactive_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/test/test_timeouts.h"
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/renderer_context_menu/render_view_context_menu_browsertest_util.h"
@@ skipping 284 matching lines @@
   EXPECT_EQ("\"child2-focused-input2\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(child2, web_contents->GetFocusedFrame());
   EXPECT_EQ("\"child2-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(child1, web_contents->GetFocusedFrame());
   EXPECT_EQ("\"child1-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ("\"root-focused-input1\"", press_tab_and_wait_for_message(true));
   EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
 }
 
-// TODO(https://crbug.com/702330): Enable this test.
+#if (defined(OS_LINUX) && !defined(USE_OZONE)) || defined(OS_WIN)

[alexmos, 2017/04/05 00:21:13]

(Carrying over the discussion from previous CL)
On 2017/04/02 02:27:30, avallee wrote:
Hmm, that's weird. Are these mousemoves really essential for this test though? 
Would things work if, instead of ui_controls::SendMouseMove/Click, you used
something like ForwardMouseEvent, or SimulateMouseClickAt from
browser_test_utils?  I think I've used these to simulate mouse clicks in tests
and haven't run into them not working on Ozone/Mac.

What about ChromeOS?  That's disabled too as it's written now.  

[avallee, 2017/04/05 15:13:00]

I've fixed the test, but requires a relatively major change to
SimulateMouseClickAt. I may need to split that out into another cl.

[alexmos, 2017/04/05 18:08:33]

I'm ok with that change - I think it'd be great for SimulateMouseClickAt to
route events into OOPIFs if they are present, especially now that we've removed
the input forwarding path.  But yes, you might want to split it into another cl
and have kenrb@ review it.  It also seems like there's one test failure due to
it (WebViewFocusInteractiveTest.Focus_FocusRestored).

An alternative to that refactor could be to use the ForwardMouseEvent directly
on the RWH of each frame, but that probably requires too many changes to your
test.

 // Ensures that renderers know to advance focus to sibling frames and parent
 // frames in the presence of mouse click initiated focus changes.
+// Verifies against regression of https://crbug.com/702330
 IN_PROC_BROWSER_TEST_F(SitePerProcessInteractiveBrowserTest,
-                       DISABLED_TabAndMouseFocusNavigation) {
+                       TabAndMouseFocusNavigation) {
   GURL main_url(embedded_test_server()->GetURL(
       "a.com", "/cross_site_iframe_factory.html?a(b,c)"));
   ui_test_utils::NavigateToURL(browser(), main_url);
 
   content::WebContents* web_contents =
       browser()->tab_strip_model()->GetActiveWebContents();
 
   content::RenderFrameHost* main_frame = web_contents->GetMainFrame();
   content::RenderFrameHost* child1 = ChildFrameAt(main_frame, 0);
   ASSERT_NE(nullptr, child1);
   content::RenderFrameHost* child2 = ChildFrameAt(main_frame, 1);
   ASSERT_NE(nullptr, child2);
 
   // Assign a name to each frame.  This will be sent along in test messages
   // from focus events.
   EXPECT_TRUE(ExecuteScript(main_frame, "window.name = 'root';"));
   EXPECT_TRUE(ExecuteScript(child1, "window.name = 'child1';"));
   EXPECT_TRUE(ExecuteScript(child2, "window.name = 'child2';"));
 
   // This script will insert two <input> fields in the document, one at the
   // beginning and one at the end.  For root frame, this means that we will
   // have an <input>, then two <iframe> elements, then another <input>.
   // The script will send back the coordinates to click for each <input>, in the
   // document's space. Additionally, the outer frame will return  the top left
   // point of each <iframe> to transform the coordinates of the inner <input>
   // elements. For example, main frame: 497,18;497,185:381,59;499,59 and each
   // iframe: 55,18;55,67
   std::string script =
       "function onFocus(e) {"
-      "  console.log(window.name+'-focused-'+ e.target.id);"
       "  domAutomationController.setAutomationId(0);"
       "  domAutomationController.send(window.name + '-focused-' + e.target.id);"
       "}"
       ""
       "function getElementCoords(element) {"
       "  var rect = element.getBoundingClientRect();"
       "  return Math.floor(rect.left + 0.5 * rect.width) +','+"
       "         Math.floor(rect.top + 0.5 * rect.height);"
       "}"
       "function getIframeCoords(element) {"
@@ skipping 76 matching lines @@
 
         std::string reply;
         EXPECT_TRUE(msg_queue.WaitForMessage(&reply));
         return reply;
       };
 
   // Tab from child1 back to root.
   EXPECT_EQ("\"root-focused-input1\"",
             click_element_and_wait_for_message(main_frame_input_coords[0]));
   EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
+  auto frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child1);
   EXPECT_EQ("\"child1-focused-input1\"",
             click_element_and_wait_for_message(child1_input_coords[0]));
-  EXPECT_EQ(child1, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(main_frame);
   EXPECT_EQ("\"root-focused-input1\"", press_tab_and_wait_for_message(true));
-  EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
+  // EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());

[alexmos, 2017/04/05 00:21:13]

nit: remove commented out line

[avallee, 2017/04/05 15:13:00]

Done.

+  frame_focused->Wait();
 
   // Tab from child2 forward to root.
   EXPECT_EQ("\"root-focused-input2\"",
             click_element_and_wait_for_message(main_frame_input_coords[1]));
   EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child2);
   EXPECT_EQ("\"child2-focused-input2\"",
             click_element_and_wait_for_message(child2_input_coords[1]));
-  EXPECT_EQ(child2, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(main_frame);
   EXPECT_EQ("\"root-focused-input2\"", press_tab_and_wait_for_message(false));
-  EXPECT_EQ(main_frame, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
 
   // Tab forward from child1 to child2.
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child2);
   EXPECT_EQ("\"child2-focused-input1\"",
             click_element_and_wait_for_message(child2_input_coords[0]));
-  EXPECT_EQ(child2, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child1);
   EXPECT_EQ("\"child1-focused-input2\"",
             click_element_and_wait_for_message(child1_input_coords[1]));
-  EXPECT_EQ(child1, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child2);
   EXPECT_EQ("\"child2-focused-input1\"", press_tab_and_wait_for_message(false));
-  EXPECT_EQ(child2, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
 
   // Tab backward from child2 to child1.
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child1);
   EXPECT_EQ("\"child1-focused-input2\"",
             click_element_and_wait_for_message(child1_input_coords[1]));
-  EXPECT_EQ(child1, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child2);
   EXPECT_EQ("\"child2-focused-input1\"",
             click_element_and_wait_for_message(child2_input_coords[0]));
-  EXPECT_EQ(child2, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
+  frame_focused = base::MakeUnique<content::FrameFocusedObserver>(child1);
   EXPECT_EQ("\"child1-focused-input2\"", press_tab_and_wait_for_message(true));
-  EXPECT_EQ(child1, web_contents->GetFocusedFrame());
+  // EXPECT_EQ(child1, web_contents->GetFocusedFrame());
+  frame_focused->Wait();
 
   // Ensure there are no pending focus events after tabbing.
   EXPECT_EQ("\"root-focused-input1\"",
             click_element_and_wait_for_message(main_frame_input_coords[0]))
       << "Unexpected extra focus events.";
 }
+#endif
 
 namespace {
 
 // Helper to retrieve the frame's (window.innerWidth, window.innerHeight).
 gfx::Size GetFrameSize(content::RenderFrameHost* frame) {
   int width = 0;
   EXPECT_TRUE(ExecuteScriptAndExtractInt(
       frame, "domAutomationController.send(window.innerWidth);", &width));
 
   int height = 0;
@@ skipping 846 matching lines @@
 
   // Ideally, the length of the error vector should be 0.0f. But due to
   // potential rounding errors, we assume a larger limit (which is slightly
   // larger than square root of 2).
   EXPECT_LT(error.Length(), 1.4143f)
       << "Origin of bounds from focused node changed event is '"
       << focus_observer.focused_node_bounds_in_screen().ToString()
       << "' but AutofillClient is reporting '" << bounds_origin.ToString()
       << "'";
 }