content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java - Issue 2796453003: android: Limit bindToCaller check to webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

Issue 2796453003: android: Limit bindToCaller check to webview (Closed)

Patch Set: rebase, removed final from chrome Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java ('k') | content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

index 64c15b75f6857ff60c91659ee2eddb7563a01474..4499622fe29b6a53d96e8c3e224efb57e03f4a94 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java

@@ -176,9 +176,11 @@ public class ChildProcessConnectionImpl implements ChildProcessConnection {

StartCallback startCallback = mStartCallback;

mStartCallback = null;

+ final boolean bindCheck =

+ mCreationParams != null && mCreationParams.getBindToCallerCheck();

boolean boundToUs = false;

try {

- boundToUs = mService.bindToCaller();

+ boundToUs = bindCheck ? mService.bindToCaller() : true;

} catch (RemoteException ex) {

// Do not trigger the StartCallback here, since the service is already

// dead and the DeathCallback will run from onServiceDisconnected().