Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Issue 2796453003: android: Limit bindToCaller check to webview (Closed)
Patch Set: fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
index ab4af328b92e8b71105f3121e4c0d0f537a29e53..5649e6e236c13fe5dee20163f461ad15780a3a43 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
@@ -388,9 +388,11 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
// Launch a service from this process. Since slot 0 is already bound by the Helper, it
// will fail to start and the ChildProcessLauncher will retry.
- final ChildProcessConnection conn = ChildProcessLauncher.startForTesting(context,
- sProcessWaitArguments, new FileDescriptorInfo[0],
- getDefaultChildProcessCreationParams(context.getPackageName()));
+ final ChildProcessCreationParams creationParams = new ChildProcessCreationParams(
+ context.getPackageName(), false /* isExternalService */,
+ LibraryProcessType.PROCESS_CHILD, true /* bindToCallerCheck */);
+ final ChildProcessConnection conn = ChildProcessLauncher.startForTesting(
+ context, sProcessWaitArguments, new FileDescriptorInfo[0], creationParams);
CriteriaHelper.pollInstrumentationThread(
new Criteria("Failed waiting for instrumentation-bound service") {
@@ -533,7 +535,7 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
private ChildProcessCreationParams getDefaultChildProcessCreationParams(String packageName) {
return new ChildProcessCreationParams(packageName, false /* isExternalService */,
- LibraryProcessType.PROCESS_CHILD);
+ LibraryProcessType.PROCESS_CHILD, false /* bindToCallerCheck */);
}
private void triggerConnectionSetup(ChildProcessConnectionImpl connection) {

Powered by Google App Engine
This is Rietveld 408576698