Issue 2796373002: many_method_calls_test sometimes passes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2796373002: many_method_calls_test sometimes passes. (Closed)

Created:
3 years, 8 months ago by floitsch

Modified:
3 years, 8 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org, Bill Hesse

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

many_method_calls_test sometimes passes. Committed: https://github.com/dart-lang/sdk/commit/167c7243c23e8ba43d0ef7c006181b5e459bba8f

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

This test passes on the buildbot, but I couldn't reproduce locally. Marking as Pass/Crash for ...

3 years, 8 months ago (2017-04-05 13:02:28 UTC) #2

floitsch

Committed patchset #1 (id:1) manually as 167c7243c23e8ba43d0ef7c006181b5e459bba8f (presubmit successful).

3 years, 8 months ago (2017-04-05 13:03:15 UTC) #4

sra1

3 years, 8 months ago (2017-04-05 19:13:35 UTC) #5

Message was sent while issue was closed.

lgtm.

I'm going to fix the underlying recursive traversal.
I think the stack frames are a different size when optimized, so it requires
compiling other stuff first.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages