Issue 2796363005: Fix bug in doWhile where it completes an error synchronously with an error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2796363005: Fix bug in doWhile where it completes an error synchronously with an error. (Closed)

Created:
3 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
3 years, 8 months ago

Reviewers:
eernst

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix bug in doWhile where it completes an error synchronously with an error. Committed: https://github.com/dart-lang/sdk/commit/add2854671ab1dd9eb81d0e567c61f7f75fb1f15

Patch Set 1 #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	sdk/lib/async/future.dart	View		2 chunks	+13 lines, -1 line	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as add2854671ab1dd9eb81d0e567c61f7f75fb1f15 (presubmit successful).

3 years, 8 months ago (2017-04-06 10:48:04 UTC) #5

eernst

3 years, 8 months ago (2017-04-06 11:45:57 UTC) #6

Message was sent while issue was closed.

LGTM, noting a typo in comment.

https://codereview.chromium.org/2796363005/diff/1/sdk/lib/async/future.dart
File sdk/lib/async/future.dart (right):

https://codereview.chromium.org/2796363005/diff/1/sdk/lib/async/future.dart#n...
sdk/lib/async/future.dart:878: // Like [_completeWIthErrorCallback] but
completes asynchronously.
Typo: `WIth` --> `With`.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages