Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
index 31e4fcf5d54daf7becbefcd11a024dbc1bb4a892..ceac674589274116bfe385a330363f2147256311 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
@@ -263,20 +263,13 @@ void AddToHomescreenDataFetcher::FetchFavicon() {
// Grab the best, largest icon we can find to represent this bookmark.
// TODO(dfalcantara): Try combining with the new BookmarksHandler once its
// rewrite is further along.
- std::vector<int> icon_types{
- favicon_base::FAVICON,
- favicon_base::TOUCH_PRECOMPOSED_ICON | favicon_base::TOUCH_ICON};
-
favicon::FaviconService* favicon_service =
FaviconServiceFactory::GetForProfile(
Profile::FromBrowserContext(web_contents()->GetBrowserContext()),
ServiceAccessType::EXPLICIT_ACCESS);
- // Using favicon if its size is not smaller than platform required size,
- // otherwise using the largest icon among all avaliable icons.
- int threshold_to_get_any_largest_icon = ideal_icon_size_in_px_ - 1;
favicon_service->GetLargestRawFaviconForPageURL(
- shortcut_info_.url, icon_types, threshold_to_get_any_largest_icon,
+ shortcut_info_.url,
base::Bind(&AddToHomescreenDataFetcher::OnFaviconFetched, this),
&favicon_task_tracker_);
}
« no previous file with comments | « no previous file | chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698