Remove preferences among favicon types when choosing large icons

components/history/core/browser/history_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 2787 matching lines @@
                                             std::vector<GURL>(1u, icon_url),
                                             favicon_base::FAVICON,
                                             GetEdgeSizesSmallAndLarge(),
                                             &bitmap_results);
   }
 
   EXPECT_EQ(0u, favicon_changed_notifications_page_urls().size());
   EXPECT_EQ(0u, favicon_changed_notifications_icon_urls().size());
 }
 
-// Tests GetFaviconsForURL with icon_types priority,
-TEST_F(HistoryBackendTest, TestGetFaviconsForURLWithIconTypesPriority) {
+// Test the favicon is returned if its size is smaller than minimal size,
+// because it is only one available.
+TEST_F(HistoryBackendTest, TestGetLargestFaviconsForURL) {
   GURL page_url("http://www.google.com");
   GURL icon_url("http://www.google.com/favicon.ico");
   GURL touch_icon_url("http://wwww.google.com/touch_icon.ico");
 
-  std::vector<SkBitmap> favicon_bitmaps;
-  favicon_bitmaps.push_back(CreateBitmap(SK_ColorBLUE, 16));
-  favicon_bitmaps.push_back(CreateBitmap(SK_ColorRED, 32));
-
-  std::vector<SkBitmap> touch_bitmaps;
-  touch_bitmaps.push_back(CreateBitmap(SK_ColorWHITE, 64));
-
-  // Set some preexisting favicons for |page_url|.
-  backend_->SetFavicons(
-      page_url, favicon_base::FAVICON, icon_url, favicon_bitmaps);
-  backend_->SetFavicons(
-      page_url, favicon_base::TOUCH_ICON, touch_icon_url, touch_bitmaps);
+  // Set preexisting favicons for |page_url|.
+  backend_->SetFavicons(page_url, favicon_base::FAVICON, icon_url,
+                        {CreateBitmap(SK_ColorBLUE, 16)});
+  backend_->SetFavicons(page_url, favicon_base::TOUCH_ICON, touch_icon_url,
+                        {CreateBitmap(SK_ColorGREEN, 64)});
 
   favicon_base::FaviconRawBitmapResult result;
-  std::vector<int> icon_types;
-  icon_types.push_back(favicon_base::FAVICON);
-  icon_types.push_back(favicon_base::TOUCH_ICON);
-
-  backend_->GetLargestFaviconForURL(page_url, icon_types, 16, &result);
-
-  // Verify the result icon is 32x32 favicon.
-  EXPECT_EQ(gfx::Size(32, 32), result.pixel_size);
-  EXPECT_EQ(favicon_base::FAVICON, result.icon_type);
-
-  // Change Minimal size to 32x32 and verify the 64x64 touch icon returned.
-  backend_->GetLargestFaviconForURL(page_url, icon_types, 32, &result);
+  backend_->GetLargestFaviconForURL(page_url, &result);
   EXPECT_EQ(gfx::Size(64, 64), result.pixel_size);
   EXPECT_EQ(favicon_base::TOUCH_ICON, result.icon_type);
 }
 
-// Test the the first types of icon is returned if its size equal to the
-// second types icon.
-TEST_F(HistoryBackendTest, TestGetFaviconsForURLReturnFavicon) {
-  GURL page_url("http://www.google.com");
-  GURL icon_url("http://www.google.com/favicon.ico");
-  GURL touch_icon_url("http://wwww.google.com/touch_icon.ico");
-
-  std::vector<SkBitmap> favicon_bitmaps;
-  favicon_bitmaps.push_back(CreateBitmap(SK_ColorBLUE, 16));
-  favicon_bitmaps.push_back(CreateBitmap(SK_ColorRED, 32));
-
-  std::vector<SkBitmap> touch_bitmaps;
-  touch_bitmaps.push_back(CreateBitmap(SK_ColorWHITE, 32));
-
-  // Set some preexisting favicons for |page_url|.
-  backend_->SetFavicons(
-      page_url, favicon_base::FAVICON, icon_url, favicon_bitmaps);
-  backend_->SetFavicons(
-      page_url, favicon_base::TOUCH_ICON, touch_icon_url, touch_bitmaps);
-
-  favicon_base::FaviconRawBitmapResult result;
-  std::vector<int> icon_types;
-  icon_types.push_back(favicon_base::FAVICON);
-  icon_types.push_back(favicon_base::TOUCH_ICON);
-
-  backend_->GetLargestFaviconForURL(page_url, icon_types, 16, &result);
-
-  // Verify the result icon is 32x32 favicon.
-  EXPECT_EQ(gfx::Size(32, 32), result.pixel_size);
-  EXPECT_EQ(favicon_base::FAVICON, result.icon_type);
-
-  // Change minimal size to 32x32 and verify the 32x32 favicon returned.
-  favicon_base::FaviconRawBitmapResult result1;
-  backend_->GetLargestFaviconForURL(page_url, icon_types, 32, &result1);
-  EXPECT_EQ(gfx::Size(32, 32), result1.pixel_size);
-  EXPECT_EQ(favicon_base::FAVICON, result1.icon_type);
-}
-
-// Test the favicon is returned if its size is smaller than minimal size,
-// because it is only one available.
-TEST_F(HistoryBackendTest, TestGetFaviconsForURLReturnFaviconEvenItSmaller) {
-  GURL page_url("http://www.google.com");
-  GURL icon_url("http://www.google.com/favicon.ico");
-
-  std::vector<SkBitmap> bitmaps;
-  bitmaps.push_back(CreateBitmap(SK_ColorBLUE, 16));
-
-  // Set preexisting favicons for |page_url|.
-  backend_->SetFavicons(page_url, favicon_base::FAVICON, icon_url, bitmaps);
-
-  favicon_base::FaviconRawBitmapResult result;
-  std::vector<int> icon_types;
-  icon_types.push_back(favicon_base::FAVICON);
-  icon_types.push_back(favicon_base::TOUCH_ICON);
-
-  backend_->GetLargestFaviconForURL(page_url, icon_types, 32, &result);
-
-  // Verify 16x16 icon is returned, even it small than minimal_size.
-  EXPECT_EQ(gfx::Size(16, 16), result.pixel_size);
-  EXPECT_EQ(favicon_base::FAVICON, result.icon_type);
-}
-
 // Test UpdateFaviconMappingsAndFetch() when multiple icon types are passed in.
 TEST_F(HistoryBackendTest, UpdateFaviconMappingsAndFetchMultipleIconTypes) {
   GURL page_url1("http://www.google.com");
   GURL page_url2("http://news.google.com");
   GURL page_url3("http://mail.google.com");
   GURL icon_urla("http://www.google.com/favicon1.ico");
   GURL icon_urlb("http://www.google.com/favicon2.ico");
   std::vector<SkBitmap> bitmaps;
   bitmaps.push_back(CreateBitmap(SK_ColorBLUE, kSmallEdgeSize));
 
@@ skipping 1006 matching lines @@
   backend_->QueryMostVisitedURLs(100, 100, &most_visited);
 
   const base::string16 kSomeTitle;  // Ignored by equality operator.
   EXPECT_THAT(
       most_visited,
       ElementsAre(MostVisitedURL(GURL("http://example1.com"), kSomeTitle),
                   MostVisitedURL(GURL("http://example5.com"), kSomeTitle)));
 }
 
 }  // namespace history