Remove preferences among favicon types when choosing large icons

components/history/core/browser/history_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/history_backend.h"
 
 #include <algorithm>
 #include <functional>
 #include <list>
 #include <map>
@@ skipping 1414 matching lines @@
     const std::vector<GURL>& icon_urls,
     int icon_types,
     const std::vector<int>& desired_sizes,
     std::vector<favicon_base::FaviconRawBitmapResult>* bitmap_results) {
   UpdateFaviconMappingsAndFetchImpl(nullptr, icon_urls, icon_types,
                                     desired_sizes, bitmap_results);
 }
 
 void HistoryBackend::GetLargestFaviconForURL(
     const GURL& page_url,
-    const std::vector<int>& icon_types,
-    int minimum_size_in_pixels,
     favicon_base::FaviconRawBitmapResult* favicon_bitmap_result) {
   DCHECK(favicon_bitmap_result);
 
   if (!db_ || !thumbnail_db_)
     return;
 
   TimeTicks beginning_time = TimeTicks::Now();
 
   std::vector<IconMapping> icon_mappings;
   if (!thumbnail_db_->GetIconMappingsForPageURL(page_url, &icon_mappings) ||
       icon_mappings.empty())
     return;
 
-  int required_icon_types = 0;
-  for (std::vector<int>::const_iterator i = icon_types.begin();
-       i != icon_types.end(); ++i) {
-    required_icon_types |= *i;
-  }
-
-  // Find the largest bitmap for each IconType placing in
-  // |largest_favicon_bitmaps|.
-  std::map<favicon_base::IconType, FaviconBitmap> largest_favicon_bitmaps;
+  // Find the largest bitmap.
+  FaviconBitmap largest_icon;
   for (std::vector<IconMapping>::const_iterator i = icon_mappings.begin();
        i != icon_mappings.end(); ++i) {
-    if (!(i->icon_type & required_icon_types))
-      continue;
     std::vector<FaviconBitmapIDSize> bitmap_id_sizes;
     thumbnail_db_->GetFaviconBitmapIDSizes(i->icon_id, &bitmap_id_sizes);
-    FaviconBitmap& largest = largest_favicon_bitmaps[i->icon_type];
     for (std::vector<FaviconBitmapIDSize>::const_iterator j =
              bitmap_id_sizes.begin();
          j != bitmap_id_sizes.end(); ++j) {
-      if (largest.bitmap_id == 0 ||
-          (largest.pixel_size.width() < j->pixel_size.width() &&
-           largest.pixel_size.height() < j->pixel_size.height())) {
-        largest.icon_id = i->icon_id;
-        largest.bitmap_id = j->bitmap_id;
-        largest.pixel_size = j->pixel_size;
+      if (largest_icon.bitmap_id == 0 ||
+          (largest_icon.pixel_size.width() < j->pixel_size.width() &&
+           largest_icon.pixel_size.height() < j->pixel_size.height())) {
+        largest_icon.icon_id = i->icon_id;
+        largest_icon.bitmap_id = j->bitmap_id;
+        largest_icon.pixel_size = j->pixel_size;
       }
     }
   }
-  if (largest_favicon_bitmaps.empty())
+  if (largest_icon.bitmap_id == 0)
     return;
 
-  // Find an icon which is larger than minimum_size_in_pixels in the order of
-  // icon_types.
-  FaviconBitmap largest_icon;
-  for (std::vector<int>::const_iterator t = icon_types.begin();
-       t != icon_types.end(); ++t) {
-    for (std::map<favicon_base::IconType, FaviconBitmap>::const_iterator f =
-             largest_favicon_bitmaps.begin();
-         f != largest_favicon_bitmaps.end(); ++f) {
-      if (f->first & *t &&
-          (largest_icon.bitmap_id == 0 ||
-           (largest_icon.pixel_size.height() < f->second.pixel_size.height() &&
-            largest_icon.pixel_size.width() < f->second.pixel_size.width()))) {
-        largest_icon = f->second;
-      }
-    }
-    if (largest_icon.pixel_size.width() > minimum_size_in_pixels &&
-        largest_icon.pixel_size.height() > minimum_size_in_pixels)
-      break;
-  }
-
   GURL icon_url;
   favicon_base::IconType icon_type;
   if (!thumbnail_db_->GetFaviconHeader(largest_icon.icon_id, &icon_url,
                                        &icon_type)) {
     return;
   }
 
   base::Time last_updated;
   favicon_base::FaviconRawBitmapResult bitmap_result;
   bitmap_result.icon_url = icon_url;
@@ skipping 1149 matching lines @@
   // transaction is currently open.
   db_->CommitTransaction();
   db_->Vacuum();
   db_->BeginTransaction();
   db_->GetStartDate(&first_recorded_time_);
 
   return true;
 }
 
 }  // namespace history