Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: components/favicon/core/large_icon_service.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_
6 #define COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_ 6 #define COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 const GURL& page_url, 90 const GURL& page_url,
91 int min_source_size_in_pixel, 91 int min_source_size_in_pixel,
92 int desired_size_in_pixel, 92 int desired_size_in_pixel,
93 const favicon_base::LargeIconCallback& raw_bitmap_callback, 93 const favicon_base::LargeIconCallback& raw_bitmap_callback,
94 const favicon_base::LargeIconImageCallback& image_callback, 94 const favicon_base::LargeIconImageCallback& image_callback,
95 base::CancelableTaskTracker* tracker); 95 base::CancelableTaskTracker* tracker);
96 96
97 FaviconService* favicon_service_; 97 FaviconService* favicon_service_;
98 scoped_refptr<base::TaskRunner> background_task_runner_; 98 scoped_refptr<base::TaskRunner> background_task_runner_;
99 99
100 // A pre-populated list of icon types to consider when looking for large
101 // icons. This is an optimization over populating an icon type vector on each
102 // request.
103 std::vector<int> large_icon_types_;
104
105 std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher_; 100 std::unique_ptr<image_fetcher::ImageFetcher> image_fetcher_;
106 101
107 DISALLOW_COPY_AND_ASSIGN(LargeIconService); 102 DISALLOW_COPY_AND_ASSIGN(LargeIconService);
108 }; 103 };
109 104
110 } // namespace favicon 105 } // namespace favicon
111 106
112 #endif // COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_ 107 #endif // COMPONENTS_FAVICON_CORE_LARGE_ICON_SERVICE_H_
OLDNEW
« no previous file with comments | « components/favicon/core/favicon_service_impl.cc ('k') | components/favicon/core/large_icon_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698