Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: components/favicon/core/favicon_service_impl.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 const favicon_base::FaviconImageCallback& callback, 62 const favicon_base::FaviconImageCallback& callback,
63 base::CancelableTaskTracker* tracker) override; 63 base::CancelableTaskTracker* tracker) override;
64 base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL( 64 base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL(
65 const GURL& page_url, 65 const GURL& page_url,
66 int icon_types, 66 int icon_types,
67 int desired_size_in_pixel, 67 int desired_size_in_pixel,
68 const favicon_base::FaviconRawBitmapCallback& callback, 68 const favicon_base::FaviconRawBitmapCallback& callback,
69 base::CancelableTaskTracker* tracker) override; 69 base::CancelableTaskTracker* tracker) override;
70 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL( 70 base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL(
71 const GURL& page_url, 71 const GURL& page_url,
72 const std::vector<int>& icon_types,
73 int minimum_size_in_pixels,
74 const favicon_base::FaviconRawBitmapCallback& callback, 72 const favicon_base::FaviconRawBitmapCallback& callback,
75 base::CancelableTaskTracker* tracker) override; 73 base::CancelableTaskTracker* tracker) override;
76 base::CancelableTaskTracker::TaskId GetFaviconForPageURL( 74 base::CancelableTaskTracker::TaskId GetFaviconForPageURL(
77 const GURL& page_url, 75 const GURL& page_url,
78 int icon_types, 76 int icon_types,
79 int desired_size_in_dip, 77 int desired_size_in_dip,
80 const favicon_base::FaviconResultsCallback& callback, 78 const favicon_base::FaviconResultsCallback& callback,
81 base::CancelableTaskTracker* tracker) override; 79 base::CancelableTaskTracker* tracker) override;
82 base::CancelableTaskTracker::TaskId UpdateFaviconMappingsAndFetch( 80 base::CancelableTaskTracker::TaskId UpdateFaviconMappingsAndFetch(
83 const GURL& page_url, 81 const GURL& page_url,
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_; 144 base::hash_set<MissingFaviconURLHash> missing_favicon_urls_;
147 std::unique_ptr<FaviconClient> favicon_client_; 145 std::unique_ptr<FaviconClient> favicon_client_;
148 history::HistoryService* history_service_; 146 history::HistoryService* history_service_;
149 147
150 DISALLOW_COPY_AND_ASSIGN(FaviconServiceImpl); 148 DISALLOW_COPY_AND_ASSIGN(FaviconServiceImpl);
151 }; 149 };
152 150
153 } // namespace favicon 151 } // namespace favicon
154 152
155 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_ 153 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « components/favicon/core/favicon_service.h ('k') | components/favicon/core/favicon_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698