Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: components/favicon/core/favicon_service.h

Issue 2796343003: Remove preferences among favicon types when choosing large icons
Patch Set: Rebased. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 // |desired_size_in_pixel| is resized. If |desired_size_in_pixel| is 0, 95 // |desired_size_in_pixel| is resized. If |desired_size_in_pixel| is 0,
96 // the largest favicon bitmap is returned. Results with a higher priority 96 // the largest favicon bitmap is returned. Results with a higher priority
97 // IconType are preferred over an exact match of the favicon bitmap size. 97 // IconType are preferred over an exact match of the favicon bitmap size.
98 virtual base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL( 98 virtual base::CancelableTaskTracker::TaskId GetRawFaviconForPageURL(
99 const GURL& page_url, 99 const GURL& page_url,
100 int icon_types, 100 int icon_types,
101 int desired_size_in_pixel, 101 int desired_size_in_pixel,
102 const favicon_base::FaviconRawBitmapCallback& callback, 102 const favicon_base::FaviconRawBitmapCallback& callback,
103 base::CancelableTaskTracker* tracker) = 0; 103 base::CancelableTaskTracker* tracker) = 0;
104 104
105 // See HistoryService::GetLargestFaviconForPageURL(). 105 // See HistoryService::GetLargestFaviconForURL().
106 virtual base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL( 106 virtual base::CancelableTaskTracker::TaskId GetLargestRawFaviconForPageURL(
107 const GURL& page_url, 107 const GURL& page_url,
108 const std::vector<int>& icon_types,
109 int minimum_size_in_pixels,
110 const favicon_base::FaviconRawBitmapCallback& callback, 108 const favicon_base::FaviconRawBitmapCallback& callback,
111 base::CancelableTaskTracker* tracker) = 0; 109 base::CancelableTaskTracker* tracker) = 0;
112 110
113 virtual base::CancelableTaskTracker::TaskId GetFaviconForPageURL( 111 virtual base::CancelableTaskTracker::TaskId GetFaviconForPageURL(
114 const GURL& page_url, 112 const GURL& page_url,
115 int icon_types, 113 int icon_types,
116 int desired_size_in_dip, 114 int desired_size_in_dip,
117 const favicon_base::FaviconResultsCallback& callback, 115 const favicon_base::FaviconResultsCallback& callback,
118 base::CancelableTaskTracker* tracker) = 0; 116 base::CancelableTaskTracker* tracker) = 0;
119 117
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 203
206 // Avoid repeated requests to download missing favicon. 204 // Avoid repeated requests to download missing favicon.
207 virtual void UnableToDownloadFavicon(const GURL& icon_url) = 0; 205 virtual void UnableToDownloadFavicon(const GURL& icon_url) = 0;
208 virtual bool WasUnableToDownloadFavicon(const GURL& icon_url) const = 0; 206 virtual bool WasUnableToDownloadFavicon(const GURL& icon_url) const = 0;
209 virtual void ClearUnableToDownloadFavicons() = 0; 207 virtual void ClearUnableToDownloadFavicons() = 0;
210 }; 208 };
211 209
212 } // namespace favicon 210 } // namespace favicon
213 211
214 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_ 212 #endif // COMPONENTS_FAVICON_CORE_FAVICON_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/app_list/search/suggestions/url_suggestion_result.cc ('k') | components/favicon/core/favicon_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698