Use non-static set_key interface on DataReductionProxySettings

android_webview/browser/net/aw_url_request_context_getter.cc

Index: android_webview/browser/net/aw_url_request_context_getter.cc
diff --git a/android_webview/browser/net/aw_url_request_context_getter.cc b/android_webview/browser/net/aw_url_request_context_getter.cc
index 2850b4459d79ad0c17d02ea449f7f20bf98dd412..c12fb4c90fda59a1ca0d190f4c69f89171f7e0fb 100644
--- a/android_webview/browser/net/aw_url_request_context_getter.cc
+++ b/android_webview/browser/net/aw_url_request_context_getter.cc
@@ -6,6 +6,7 @@
 
 #include <vector>
 
+#include "android_webview/browser/aw_browser_context.h"
 #include "android_webview/browser/aw_content_browser_client.h"
 #include "android_webview/browser/aw_request_interceptor.h"
 #include "android_webview/browser/net/aw_network_delegate.h"
@@ -215,8 +216,13 @@ void AwURLRequestContextGetter::InitializeURLRequestContext() {
           20 * 1024 * 1024,  // 20M
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)));
 
+  AwBrowserContext* browser_context = AwBrowserContext::GetDefault();
+  DCHECK(browser_context);
+  DataReductionProxySettings* drp_settings =
+      browser_context->GetDataReductionProxySettings();
+  DCHECK(drp_settings);
   DataReductionProxySettings::InitDataReductionProxySession(
-      main_cache->GetSession());
+      main_cache->GetSession(), drp_settings->key());

[sgurun-gerrit only, 2014/05/09 00:58:28]

I am not sure about this logic. The key may not be set by the time
InitDataReductionProxySession is called. Does this have to happen here?

[bengr, 2014/05/09 03:16:51]

InitDataReductionProxySession constructs credentials to be used. It must be
called zero or one time, and if it is called, it must be called before any
requests are sent to the data reduction proxy. Do you have a better place? 

For now, we could remove this call, and credentials would be constructed on the
first request. (The data reduction proxy responds with an authentication
challenge if credentials are not provided.) The drawback to removing this call
is the latency of an extra round trip on the first request of each session.

 
   main_http_factory_.reset(main_cache);
   url_request_context_->set_http_transaction_factory(main_cache);