components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc - Issue 279633003: Use non-static set_key interface on DataReductionProxySettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

Issue 279633003: Use non-static set_key interface on DataReductionProxySettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gyp Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.h ('k') | components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

index 04665fb33485ba1b0abcc52afb6d339b8b0d1ebf..1158748b17cae2b1559e2ce55a224a40c7593bb7 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_auth_request_handler.cc

@@ -33,7 +33,8 @@ int64

DataReductionProxyAuthRequestHandler::auth_token_invalidation_timestamp_ = 0;

-DataReductionProxyAuthRequestHandler::DataReductionProxyAuthRequestHandler() {

+DataReductionProxyAuthRequestHandler::DataReductionProxyAuthRequestHandler(

+ DataReductionProxySettings* settings) : settings_(settings) {

}

DataReductionProxyAuthRequestHandler::~DataReductionProxyAuthRequestHandler() {

@@ -108,7 +109,8 @@ bool DataReductionProxyAuthRequestHandler::IsAcceptableAuthChallenge(

base::string16 DataReductionProxyAuthRequestHandler::GetTokenForAuthChallenge(

net::AuthChallengeInfo* auth_info) {

- return DataReductionProxySettings::GetTokenForAuthChallenge(auth_info);

+ DCHECK(settings_);

+ return settings_->GetTokenForAuthChallenge(auth_info);

}

base::TimeTicks DataReductionProxyAuthRequestHandler::Now() {