Use non-static set_key interface on DataReductionProxySettings

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
@@ skipping 444 matching lines @@
           lazy_params_->cache_max_size,
           BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE)
               .get());
   net::HttpNetworkSession::Params network_session_params;
   PopulateNetworkSessionParams(profile_params, &network_session_params);
   net::HttpCache* main_cache = new net::HttpCache(
       network_session_params, main_backend);
   main_cache->InitializeInfiniteCache(lazy_params_->infinite_cache_path);
 
 #if defined(OS_ANDROID) || defined(OS_IOS)
+#if defined(SPDY_PROXY_AUTH_VALUE)

[mmenke, 2014/05/09 15:27:08]

Is this double #if really needed?

[bengr, 2014/05/09 15:47:28]

Done.

[piman, 2014/05/12 19:19:24]

Actually... it is.
clank/supplemental.gypi which makes this defined is sourced if present,
regardless of the platform. However, DataReductionProxySettings is not present
on regular linux builds, so if you build that with clank/ checked out, it fails
to build.

[mmenke, 2014/05/12 19:21:58]

I think it would make more sense to make it not defined, rather than to modify C
files.  Otherwise, we have SPDY_PROXY_AUTH_VALUE defined, but aren't really
supporting it, which is odd, and affects a bunch of other files as well.

   data_reduction_proxy::DataReductionProxySettings::
-      InitDataReductionProxySession(main_cache->GetSession());
+      InitDataReductionProxySession(main_cache->GetSession(),
+                                    SPDY_PROXY_AUTH_VALUE);
+#endif
 #endif
 
   if (chrome_browser_net::ShouldUseInMemoryCookiesAndCache()) {
     main_cache->set_mode(
         chrome_browser_net::IsCookieRecordMode() ?
         net::HttpCache::RECORD : net::HttpCache::PLAYBACK);
   }
 
   main_http_factory_.reset(main_cache);
   main_context->set_http_transaction_factory(main_cache);
@@ skipping 255 matching lines @@
     const base::Closure& completion) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DCHECK(initialized());
 
   DCHECK(transport_security_state());
   // Completes synchronously.
   transport_security_state()->DeleteAllDynamicDataSince(time);
   DCHECK(http_server_properties_manager_);
   http_server_properties_manager_->Clear(completion);
 }