Network traffic annotation added to translate_url_fetcher.

components/translate/core/browser/translate_url_fetcher.cc

Index: components/translate/core/browser/translate_url_fetcher.cc
diff --git a/components/translate/core/browser/translate_url_fetcher.cc b/components/translate/core/browser/translate_url_fetcher.cc
index dbbff3176056f9c9c199a3e1e7c84e4503213316..e6316e214f39d0f65e0d452ab2cb8b6846654ed7 100644
--- a/components/translate/core/browser/translate_url_fetcher.cc
+++ b/components/translate/core/browser/translate_url_fetcher.cc
@@ -8,6 +8,7 @@
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 
@@ -46,7 +47,55 @@ bool TranslateURLFetcher::Request(
   url_ = url;
   callback_ = callback;
 
-  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("translate_url_fetcher", R"(
+        semantics {
+          sender: "Translate"
+          description:
+            "Chrome can provide translations for the web sites visited by the "
+            "user. If this feature is enabled, Chrome sends network requests "
+            "to download the list of supported languages, a library to perform "
+            "translations, and a predictive model to know when to offer "
+            "translation."
+          trigger:
+            "When Chrome starts, it downloads the list of supported langagues "
+            "for translation, and a predictive model to detect the language of "

[Roger McFarlane (Chromium), 2017/04/18 20:48:19]

The predictive model isn't for language detection; it predicts the utility of
prompting the user with the translation (what is the probability the user
actually wants/needs the translation).

The language detection model is statically linked to Chrome (i.e., not
downloaded).

[Ramin Halavati, 2017/04/19 06:07:05]

Done.

[Roger McFarlane (Chromium), 2017/05/03 14:34:09]

I'm not sure why you removed so much text. There seems to be some confusion.

There are two models:

 - language detection model: statically linked to chrome

 - predictive model to infer whether a translation from
   the detected language to some other language would be
   useful/accepted by the user. This is downloaded and
   cached when chrome starts.

The previous version of the annotation seemed to be conflating these two models.
My comment was that the predictive model is not the same thing as the language
detection model (the latter of which is not downloaded).

[Ramin Halavati, 2017/05/03 15:20:40]

Oh sorry, I misunderstood it.

+            "web pages. The model is cached and the link to the latest model "
+            "is provided by field study. If latest model is already cached, it "
+            "is not fetched. The first time the model decides to offer "
+            "translation of a web site, it triggers a popup to ask if user "
+            "wants a translation and if user approves, translation library is "
+            "downloaded. The library is cached for a day and is not fetched if "
+            "it is available and fresh."
+          data:
+            "Current locale is sent to fetch the list of supperted lanaguges. "
+            "Translation library that is obtained via this interface would "
+            "perform actual translation, and it will send words and phrases in "
+            "the site to the server to translate it, but this request doesn't "
+            "send any words."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can enable/disable this feature by toggling 'Offer to "
+            "translate pages that aren't in a language you read.' in Chrome "
+            "settings under Languages. The list of supported languages is "
+            "downloaded regardless of the settings."
+          chrome_policy {
+            TranslateEnabled {
+              policy_options {mode: MANDATORY}
+              TranslateEnabled: false
+            }
+          }
+          policy_exception_justification:
+            "There is no policy for disabling download of the list of "
+            "supported languages. It is considered not required as the list is "
+            "needed for rendering user interfaces, and Chrome does not send "
+            "privacy/security sensitive data to the server on downloading it."
+        })");
+  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this,
+                                     traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |