Network traffic annotation added to translate_url_fetcher.

components/translate/core/browser/translate_url_fetcher.cc

Index: components/translate/core/browser/translate_url_fetcher.cc
diff --git a/components/translate/core/browser/translate_url_fetcher.cc b/components/translate/core/browser/translate_url_fetcher.cc
index dbbff3176056f9c9c199a3e1e7c84e4503213316..8b636454efbd1b81ec80b3e8e0d5561ea245df9d 100644
--- a/components/translate/core/browser/translate_url_fetcher.cc
+++ b/components/translate/core/browser/translate_url_fetcher.cc
@@ -8,6 +8,7 @@
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 
@@ -46,7 +47,55 @@ bool TranslateURLFetcher::Request(
   url_ = url;
   callback_ = callback;
 
-  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("translate_url_fetcher", R"(
+        semantics {
+          sender: "Translate"
+          description:
+            "Chromium can provide translations for the web sites visited by "

[Takashi Toyoshima, 2017/04/18 07:27:36]

Sorry, one more nits.
According to the style guideline, we should not use "Chromium" in the code base,
but use "Chrome" instead, even for the open sourced builds.

https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

[Ramin Halavati, 2017/04/18 07:58:00]

You are right. We had missed this rule. I will change this CL and will create
another CL in future to revert all Chromiums to Chrome.

+            "the user. If this feature is enabled, Chromium sends network "

[Takashi Toyoshima, 2017/04/18 07:27:36]

ditto

[Ramin Halavati, 2017/04/18 07:58:00]

Done.

+            "requests to download the list of supported languages, a library "
+            "to perform translations, and a predictive model to know when to "
+            "offer translation."
+          trigger:
+            "When Chromium starts, it downloads the list of supported "

[Takashi Toyoshima, 2017/04/18 07:27:36]

ditto

[Ramin Halavati, 2017/04/18 07:58:00]

Done.

+            "langagues for translation, and a predictive model to detect the "
+            "language of web pages. The model is cached and the link to the "
+            "latest model is provided by field study. If latest model is "
+            "already cached, it is not fetched. The first time the model "
+            "decides to offer translation of a web site, it triggers a popup "
+            "to ask if user wants a translation and if user approves, "
+            "translation library is downloaded. The library is cached for a "
+            "day and is not fetched if it is available and fresh."
+          data:
+            "Current locale is sent to fetch the list of supperted lanaguges. "
+            "Translation library that is obtained via this interface would "
+            "perform actual translation, and it will send words and phrases in "
+            "the site to the server to translate it, but this request doesn't "
+            "send any words."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can enable/disable this feature by toggling 'Offer to "
+            "translate pages that aren't in a language you read.' in Chromium "

[Takashi Toyoshima, 2017/04/18 07:27:36]

ditto

[Ramin Halavati, 2017/04/18 07:58:00]

Done.

+            "settings under Languages. The list of supported languages is "
+            "downloaded regardless of the settings."
+          chrome_policy {
+            TranslateEnabled {
+              policy_options {mode: MANDATORY}
+              TranslateEnabled: false
+            }
+          }
+          policy_exception_justification:
+            "There is no policy for disabling download of the list of "
+            "supported languages. It is considered not required as the list is "
+            "needed for rendering user interfaces, and Chrome does not send "
+            "privacy/security sensitive data to the server on downloading it."
+        })");
+  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this,
+                                     traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |