Network traffic annotation added to translate_url_fetcher.

components/translate/core/browser/translate_url_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_url_fetcher.h"
 
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 
 namespace translate {
 
 namespace {
 
 // Retry parameter for fetching.
 const int kMaxRetry = 16;
 
@@ skipping 18 matching lines @@
   }
 
   if (retry_count_ >= kMaxRetry)
     return false;
   retry_count_++;
 
   state_ = REQUESTING;
   url_ = url;
   callback_ = callback;
 
-  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("translate_url_fetcher", R"(
+        semantics {
+          sender: "Translate"
+          description:
+            "Chromium can provide translations for the web sites visited by "
+            "the user. If this feature is enabled, Chromium sends network "
+            "requests to download the list of supported languages, a library "
+            "to perform translations, and a predictive model to know when to "
+            "offer translation."
+          trigger:
+            "When Chromium starts, it downloads the list of supported "
+            "langagues for translation, and a predictive model to detect the "
+            "language of web pages. The model is cached and the link to the "
+            "latest model is provided by finch. If latest model is already "

[Takashi Toyoshima, 2017/04/18 07:00:08]

Probably, we should not use the word 'finch' outside chrome/ directory? "field
trial" or "field study" is the common word to explain this in content, blink,
and probably in components.

[Ramin Halavati, 2017/04/18 07:08:14]

Done.

+            "cached, it is not fetched. The first time the model decides to "
+            "offer translation of a web site, it triggers a popup to ask if "
+            "user wants a translation and if user approves, translation "
+            "library is downloaded. The library is cached for a day and is not "
+            "fetched if it is available and fresh."
+          data:
+            "Current local is sent to fetch the list of supperted lanaguges. "

[Takashi Toyoshima, 2017/04/18 07:00:08]

s/local/locale/

[Ramin Halavati, 2017/04/18 07:08:14]

Done.

+            "Translation library that is obtained via this interface would "
+            "perform actual translation, and it will send words and phrases in "
+            "the site to the server to translate it, but this request doesn't "
+            "send any words."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can enable/disable this feature by toggling 'Offer to "
+            "translate pages that aren't in a language you read.' in Chromium "
+            "settings under Languages."

[Takashi Toyoshima, 2017/04/18 07:00:08]

Sorry for changing explanations, but could you also say that "but the list of
supported language will be downloaded regardless of the setting".

[Ramin Halavati, 2017/04/18 07:08:14]

Done, thanks for being very precise about it.

+          chrome_policy {
+            TranslateEnabled {
+              policy_options {mode: MANDATORY}
+              TranslateEnabled: false
+            }
+          }

[Takashi Toyoshima, 2017/04/18 07:00:08]

shall we have the policy_exception_justification entry too, for the language
list downloads?

Justification: the list is needed for rendering user interfaces, and Chrome does
not send privacy/security sensitive data to the server on downloading it.

Please visit https://bugs.chromium.org/p/chromium/issues/detail?id=711217#c6 to
see related discussions and PM's decision.

[Ramin Halavati, 2017/04/18 07:08:14]

Done, I have added it, we will make a decision in the next round of reviewing
annotations on precise guidelines when both policy and exception justification
are available. We might add a new field for it.

+        })");
+  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this,
+                                     traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetRequestContext(
       TranslateDownloadManager::GetInstance()->request_context());
   // Set retry parameter for HTTP status code 5xx. This doesn't work against
   // 106 (net::ERR_INTERNET_DISCONNECTED) and so on.
   // TranslateLanguageList handles network status, and implements retry.
   fetcher_->SetMaxRetriesOn5xx(max_retry_on_5xx_);
@@ skipping 16 matching lines @@
   } else {
     state_ = FAILED;
   }
 
   // Transfer URLFetcher's ownership before invoking a callback.
   std::unique_ptr<const net::URLFetcher> delete_ptr(fetcher_.release());
   callback_.Run(id_, state_ == COMPLETED, data);
 }
 
 }  // namespace translate