Network traffic annotation added to translate_url_fetcher.

components/translate/core/browser/translate_url_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_url_fetcher.h"
 
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 
 namespace translate {
 
 namespace {
 
 // Retry parameter for fetching.
 const int kMaxRetry = 16;
 
@@ skipping 18 matching lines @@
   }
 
   if (retry_count_ >= kMaxRetry)
     return false;
   retry_count_++;
 
   state_ = REQUESTING;
   url_ = url;
   callback_ = callback;
 
-  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("translate_url_fetcher", R"(
+        semantics {
+          sender: "Translate"
+          description:
+            "Chromium can provide translation of web sites that user visits "
+            "through Google Translate service. If the feature is enabled, "
+            "Chromium makes a network request to Google Translate service to "
+            "know supporting languages, and to fetch a library to perform "
+            "translations."
+          trigger:
+            "When Chromium translates a web site, it triggers a request to "
+            "fetch the supporting language list in the first translation, and "
+            "will trigger another request to fetch the library once a day to "
+            "make sure it is up to date."
+          data:
+            "Translation library that is obtained via this interface would "
+            "perform actual translation, and it will send words and phrases in "
+            "the site to the server to translate it. But requests that "
+            "TranslateURLFetcher makes should not send anything."

[Ramin Halavati, 2017/04/10 13:28:26]

So my understanding is that this network request just asks for the list, without
any parameters, and asks for libraries, by sending language code.
Actual 'sending the words' are done by another requests from the library and not
routed through this request.
Am I right?

[Takashi Toyoshima, 2017/04/11 06:39:26]

Yes, right.

That library is written in JavaScript, and Chrome Translate injects the script
into the translating page behind a dedicated v8 isolated world. Since 'sending
the words' are performed by the injected script, it does not use net::URLFetcher
directly, but it just uses HTML/JavaScript functionalities to communicate with
the server.

[Ramin Halavati, 2017/04/11 06:57:29]

Done.

+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can enable/disable this feature by toggling 'Offer to "
+            "translate pages that aren't in a language you read.' in Chromium "
+            "settings under Languages."
+          chrome_policy {
+            TranslateEnabled {
+              policy_options {mode: MANDATORY}
+              TranslateEnabled: false
+            }
+          }
+        })");
+  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this,
+                                     traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetRequestContext(
       TranslateDownloadManager::GetInstance()->request_context());
   // Set retry parameter for HTTP status code 5xx. This doesn't work against
   // 106 (net::ERR_INTERNET_DISCONNECTED) and so on.
   // TranslateLanguageList handles network status, and implements retry.
   fetcher_->SetMaxRetriesOn5xx(max_retry_on_5xx_);
@@ skipping 16 matching lines @@
   } else {
     state_ = FAILED;
   }
 
   // Transfer URLFetcher's ownership before invoking a callback.
   std::unique_ptr<const net::URLFetcher> delete_ptr(fetcher_.release());
   callback_.Run(id_, state_ == COMPLETED, data);
 }
 
 }  // namespace translate