Network traffic annotation added to translate_url_fetcher.

components/translate/core/browser/translate_url_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_url_fetcher.h"
 
 #include "components/data_use_measurement/core/data_use_user_data.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "net/base/load_flags.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_status.h"
 
 namespace translate {
 
 namespace {
 
 // Retry parameter for fetching.
 const int kMaxRetry = 16;
 
@@ skipping 18 matching lines @@
   }
 
   if (retry_count_ >= kMaxRetry)
     return false;
   retry_count_++;
 
   state_ = REQUESTING;
   url_ = url;
   callback_ = callback;
 
-  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =

[Takashi Toyoshima, 2017/04/10 09:18:58]

rogerm: can you modify following my descriptions to followup ranker_model?
ranker_model_loader also uses TranslateURLFetcher, but I'm not familiar with it.

+      net::DefineNetworkTrafficAnnotation("...", R"(
+        semantics {
+          sender: "..."

[Takashi Toyoshima, 2017/04/10 09:18:57]

sender: "translate"

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+          description: "..."

[Takashi Toyoshima, 2017/04/10 09:18:58]

description: "Chrome can provide a feature to translate user visiting web sites
through Google Translate service. If the feature is enabled, Chrome makes a
network request for Google Translate service to know supporting languages, and
to fetch a library to perform translations"

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

[Roger McFarlane (Chromium), 2017/04/10 15:51:03]

How about:

Chrome can provide translations for the web sites visited by the  user. If this
feature is enabled, Chrome sends network requests on startup to download the
list of supported languages, a library to perform translations, and a predictive
model to know when to offer translation.

[Takashi Toyoshima, 2017/04/11 06:39:26]

Thanks, Roger.

Ramin, can you update your patch set with this modified description?

[Ramin Halavati, 2017/04/11 06:57:29]

Done.

+          trigger: "..."

[Takashi Toyoshima, 2017/04/10 09:18:57]

trigger: "When Chrome translates a web site, it triggers a request to fetch a
supporting language list in the first translation, and will trigger another
request to fetch the library once a day to make sure it is up to date."

[Ramin Halavati, 2017/04/11 06:57:29]

Done.

+          data: "..."

[Takashi Toyoshima, 2017/04/10 09:18:57]

data: "Translation library that is obtained via this interface would perform
actual translation, and it will send words and phrases in the site to the server
to translate it. But requests that TranslateURLFetcher make should not send
anything".

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[Takashi Toyoshima, 2017/04/10 09:18:57]

destination: GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+        }
+        policy {
+          cookies_allowed: false
+          setting: "..."

[Takashi Toyoshima, 2017/04/10 09:18:58]

setting: "chrome://settings/ Languages section has a setting to offer
translations and it should stop making network requests for fetching the
language list and the library."

I'm not sure if this setting affects ranker_model too.

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+          chrome_policy {
+            [POLICY_NAME] {
+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}

[Takashi Toyoshima, 2017/04/10 09:18:58]

policy_options: RECOMMENDED (according to
http://dev.chromium.org/administrators/policy-list-3)

[Ramin Halavati, 2017/04/10 13:28:26]

Thank you.
RECOMMENDED=true is the default case. Here we set the value that disables it
which is MANDATORY=false.

[Takashi Toyoshima, 2017/04/11 06:39:26]

Thank you for correction.

+              [POLICY_NAME]: ... //(value to disable it)

[Takashi Toyoshima, 2017/04/10 09:18:58]

POLICY_NAME is TranslateEnabled. I think disabling value is "false", but I
didn't try it. This policy should overwrite the user setting of
chrome://settings.

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+            }
+          }
+          policy_exception_justification: "..."

[Takashi Toyoshima, 2017/04/10 09:18:57]

n/a

[Ramin Halavati, 2017/04/10 13:28:26]

Done.

+        })");
+  fetcher_ = net::URLFetcher::Create(id_, url_, net::URLFetcher::GET, this,
+                                     traffic_annotation);
   data_use_measurement::DataUseUserData::AttachToFetcher(
       fetcher_.get(), data_use_measurement::DataUseUserData::TRANSLATE);
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetRequestContext(
       TranslateDownloadManager::GetInstance()->request_context());
   // Set retry parameter for HTTP status code 5xx. This doesn't work against
   // 106 (net::ERR_INTERNET_DISCONNECTED) and so on.
   // TranslateLanguageList handles network status, and implements retry.
   fetcher_->SetMaxRetriesOn5xx(max_retry_on_5xx_);
@@ skipping 16 matching lines @@
   } else {
     state_ = FAILED;
   }
 
   // Transfer URLFetcher's ownership before invoking a callback.
   std::unique_ptr<const net::URLFetcher> delete_ptr(fetcher_.release());
   callback_.Run(id_, state_ == COMPLETED, data);
 }
 
 }  // namespace translate