Do not create method extractors during JitOptimizer::TryExpandClassesInICData.

Do not create method extractors during JitOptimizer::TryExpandClassesInICData.

Closes #29230
Issue #29292
Issue #29293

R=erikcorry@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/170bf109046b42724643ae4905533f3f13b564b2

[rmacnak, 2017-04-06 22:24:24]

rmacnak@google.com changed reviewers:
+ asiva@google.com, vegorov@google.com

[Vyacheslav Egorov (Google), 2017-04-07 05:53:00]

Nice catch! LGTM

https://codereview.chromium.org/2796283006/diff/1/runtime/vm/jit_optimizer.cc
File runtime/vm/jit_optimizer.cc (right):

https://codereview.chromium.org/2796283006/diff/1/runtime/vm/jit_optimizer.cc...
runtime/vm/jit_optimizer.cc:1463: Function::Handle(Z,
Resolver::ResolveDynamicForReceiverClass(
How about adding an assertion into ResolveDynamicForReceiverClass (and friends)
that allow_add implies IsMutatorOrAtSafepoint?

[erikcorry, 2017-04-07 07:48:41]

erikcorry@google.com changed reviewers:
+ erikcorry@google.com

[erikcorry, 2017-04-07 07:48:41]

Oops, thanks for fixing.

Perhaps there should not be a default for this argument, since the current
default is dangerous.

[erikcorry, 2017-04-07 07:48:49]

lgtm

[rmacnak, 2017-04-07 16:42:50]

On 2017/04/07 07:48:41, erikcorry wrote:
> Oops, thanks for fixing.
> 
> Perhaps there should not be a default for this argument, since the current
> default is dangerous.

Good point. I'll do that in the next CL fixing the related issue 29292.

[rmacnak, 2017-04-07 16:42:57]

https://codereview.chromium.org/2796283006/diff/1/runtime/vm/jit_optimizer.cc
File runtime/vm/jit_optimizer.cc (right):

https://codereview.chromium.org/2796283006/diff/1/runtime/vm/jit_optimizer.cc...
runtime/vm/jit_optimizer.cc:1463: Function::Handle(Z,
Resolver::ResolveDynamicForReceiverClass(
On 2017/04/07 05:53:00, Vyacheslav Egorov (Google) wrote:
> How about adding an assertion into ResolveDynamicForReceiverClass (and
friends)
> that allow_add implies IsMutatorOrAtSafepoint?

It fails. I created https://github.com/dart-lang/sdk/issues/29292 to address
this.

[rmacnak, 2017-04-07 16:45:15]

Description was changed from

==========
Do not create method extractors during JitOptimizer::TryExpandClassesInICData.

Closes #29230
Issue #29292
Issue #29293
==========

to

==========
Do not create method extractors during JitOptimizer::TryExpandClassesInICData.

Closes #29230
Issue #29292
Issue #29293

R=erikcorry@google.com, vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/170bf109046b42724643ae4905533f3f13b564b2
==========

[rmacnak, 2017-04-07 16:45:16]

Committed patchset #1 (id:1) manually as
170bf109046b42724643ae4905533f3f13b564b2 (presubmit successful).