Adding UseCounter specific for extensions

third_party/WebKit/Source/core/frame/UseCounter.cpp

 /*
  * Copyright (C) 2012 Google, Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1083 matching lines @@
       NOTREACHED();
       return 0;
   }
 
   NOTREACHED();
   return 0;
 }
 
 UseCounter::UseCounter(Context context)
     : mute_count_(0),
-      disable_reporting_(false),
       context_(context),
       features_recorded_(kNumberOfFeatures),
       css_recorded_(numCSSPropertyIDs),
       animated_css_recorded_(numCSSPropertyIDs) {}
 
 void UseCounter::MuteForInspector() {
   mute_count_++;
 }
 
 void UseCounter::UnmuteForInspector() {
   mute_count_--;
 }
 
 void UseCounter::RecordMeasurement(Feature feature) {
   if (mute_count_)
     return;
 
   DCHECK(feature != kOBSOLETE_PageDestruction &&
          feature !=
              kPageVisits);  // PageDestruction is reserved as a scaling factor.
   DCHECK(feature < kNumberOfFeatures);
 
   if (!features_recorded_.QuickGet(feature)) {
     // Note that HTTPArchive tooling looks specifically for this event - see
     // https://github.com/HTTPArchive/httparchive/issues/59
-    if (!disable_reporting_) {
+    if (context_ != kDisabledContext) {
       TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"),
                    "FeatureFirstUsed", "feature", feature);
       FeaturesHistogram().Count(feature);
       NotifyFeatureCounted(feature);
     }
     features_recorded_.QuickSet(feature);
   }
   legacy_counter_.CountFeature(feature);
 }
 
@@ skipping 10 matching lines @@
 }
 
 DEFINE_TRACE(UseCounter) {
   visitor->Trace(observers_);
 }
 
 void UseCounter::DidCommitLoad(KURL url) {
   legacy_counter_.UpdateMeasurements();
 
   // Reset state from previous load.
-  disable_reporting_ = false;
-
   // Use the protocol of the document being loaded into the main frame to
   // decide whether this page is interesting from a metrics perspective.
   // Note that SVGImage cases always have an about:blank URL
-  if (context_ == kDefaultContext &&
-      !SchemeRegistry::ShouldTrackUsageMetricsForScheme(url.Protocol())) {
-    disable_reporting_ = true;
+  if (context_ != kSVGImageContext) {
+    if (url.ProtocolIs("chrome-extension"))
+      context_ = kExtensionContext;
+    else if (SchemeRegistry::ShouldTrackUsageMetricsForScheme(url.Protocol()))
+      context_ = kDefaultContext;
+    else
+      context_ = kDisabledContext;
   }
 
   features_recorded_.ClearAll();
   css_recorded_.ClearAll();
   animated_css_recorded_.ClearAll();
-  if (!disable_reporting_ && !mute_count_) {
+  if (context_ != kDisabledContext && !mute_count_) {
     FeaturesHistogram().Count(kPageVisits);
-    CssHistogram().Count(totalPagesMeasuredCSSSampleId());
-    AnimatedCSSHistogram().Count(totalPagesMeasuredCSSSampleId());
+    if (context_ != kExtensionContext) {
+      CssHistogram().Count(totalPagesMeasuredCSSSampleId());
+      AnimatedCSSHistogram().Count(totalPagesMeasuredCSSSampleId());
+    }
   }
 }
 
 void UseCounter::Count(const Frame* frame, Feature feature) {
   if (!frame)
     return;
   Page* page = frame->GetPage();
   if (!page)
     return;
 
@@ skipping 52 matching lines @@
 void UseCounter::Count(CSSParserMode css_parser_mode, CSSPropertyID property) {
   DCHECK(isCSSPropertyIDWithName(property) || property == CSSPropertyVariable);
 
   if (!IsUseCounterEnabledForMode(css_parser_mode) || mute_count_)
     return;
 
   if (!css_recorded_.QuickGet(property)) {
     // Note that HTTPArchive tooling looks specifically for this event - see
     // https://github.com/HTTPArchive/httparchive/issues/59
     int sample_id = MapCSSPropertyIdToCSSSampleIdForHistogram(property);
-    if (!disable_reporting_) {
+    if (context_ != kDisabledContext && context_ != kExtensionContext) {
       TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"),
                    "CSSFirstUsed", "feature", sample_id);
       CssHistogram().Count(sample_id);
     }
     css_recorded_.QuickSet(property);
   }
   legacy_counter_.CountCSS(property);
 }
 
 void UseCounter::Count(Feature feature) {
@@ skipping 26 matching lines @@
 }
 
 void UseCounter::CountAnimatedCSS(CSSPropertyID property) {
   DCHECK(isCSSPropertyIDWithName(property) || property == CSSPropertyVariable);
 
   if (mute_count_)
     return;
 
   if (!animated_css_recorded_.QuickGet(property)) {
     int sample_id = MapCSSPropertyIdToCSSSampleIdForHistogram(property);
-    if (!disable_reporting_) {
+    if (context_ != kDisabledContext && context_ != kExtensionContext) {
       TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"),
                    "AnimatedCSSFirstUsed", "feature", sample_id);
       AnimatedCSSHistogram().Count(sample_id);
     }
     animated_css_recorded_.QuickSet(property);
   }
 }
 
 void UseCounter::NotifyFeatureCounted(Feature feature) {
   DCHECK(!mute_count_);
-  DCHECK(!disable_reporting_);
+  DCHECK(context_ != kDisabledContext);

[Alexei Svitkine (slow), 2017/05/10 15:17:30]

DCHECK_NE

[lunalu1, 2017/05/10 19:39:38]

Done. Updated a few other DCHECK's too.

   HeapHashSet<Member<Observer>> to_be_removed;
   for (auto observer : observers_) {
     if (observer->OnCountFeature(feature))
       to_be_removed.insert(observer);
   }
   observers_.RemoveAll(to_be_removed);
 }
 
 EnumerationHistogram& UseCounter::FeaturesHistogram() const {
+  DCHECK_NE(kDisabledContext, context_);
   // Every SVGImage has it's own Page instance, and multiple web pages can
   // share the usage of a single SVGImage.  Ideally perhaps we'd delegate
   // metrics from an SVGImage to one of the Page's it's displayed in, but
   // that's tricky (SVGImage is intentionally isolated, and the Page that
   // created it may not even exist anymore).
   // So instead we just use a dedicated histogram for the SVG case.
+  DEFINE_STATIC_LOCAL(blink::EnumerationHistogram, svg_histogram,
+                      ("Blink.UseCounter.SVGImage.Features",
+                       blink::UseCounter::kNumberOfFeatures));
+  DEFINE_STATIC_LOCAL(blink::EnumerationHistogram, extension_histogram,
+                      ("Blink.UseCounter.Extensions.Features",
+                       blink::UseCounter::kNumberOfFeatures));
   DEFINE_STATIC_LOCAL(
       blink::EnumerationHistogram, histogram,
       ("Blink.UseCounter.Features", blink::UseCounter::kNumberOfFeatures));
-  DEFINE_STATIC_LOCAL(blink::EnumerationHistogram, svg_histogram,
-                      ("Blink.UseCounter.SVGImage.Features",
-                       blink::UseCounter::kNumberOfFeatures));
-
-  return context_ == kSVGImageContext ? svg_histogram : histogram;
+  switch (context_) {
+    case kSVGImageContext:
+      return svg_histogram;
+    case kExtensionContext:
+      return extension_histogram;
+    default:

[Alexei Svitkine (slow), 2017/05/10 15:17:30]

Nit: Suggest not having a default clause and explicitly handling all the cases.
This way, if a new one is added, compiler will warn the CL author to update the
switch.

[lunalu1, 2017/05/10 19:39:38]

Done.

+      return histogram;
+  }
 }
 
 EnumerationHistogram& UseCounter::CssHistogram() const {
+  DCHECK_NE(kExtensionContext, context_);
+  DCHECK_NE(kDisabledContext, context_);
   DEFINE_STATIC_LOCAL(blink::EnumerationHistogram, histogram,
                       ("Blink.UseCounter.CSSProperties", kMaximumCSSSampleId));
   DEFINE_STATIC_LOCAL(
       blink::EnumerationHistogram, svg_histogram,
       ("Blink.UseCounter.SVGImage.CSSProperties", kMaximumCSSSampleId));
 
   return context_ == kSVGImageContext ? svg_histogram : histogram;
 }
 
 EnumerationHistogram& UseCounter::AnimatedCSSHistogram() const {
@@ skipping 65 matching lines @@
     }
   }
 
   if (needs_pages_measured_update)
     css_properties_histogram.Count(totalPagesMeasuredCSSSampleId());
 
   css_bits_.ClearAll();
 }
 
 }  // namespace blink