Adding UseCounter specific for extensions

third_party/WebKit/Source/core/frame/UseCounterTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/Deprecation.h"
 #include "core/frame/UseCounter.h"
 #include "core/page/Page.h"
 #include "core/testing/DummyPageHolder.h"
 #include "platform/testing/HistogramTester.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/weborigin/KURL.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 const char* const kFeaturesHistogramName = "Blink.UseCounter.Features";
 const char* const kCSSHistogramName = "Blink.UseCounter.CSSProperties";
 const char* const kAnimatedCSSHistogramName =
     "Blink.UseCounter.AnimatedCSSProperties";
+const char* const kExtensionFeaturesHistogramName =

[Rick Byers, 2017/04/28 15:04:40]

nit: please add this to the unaffected_histograms list for other tests.  I know
it's getting a little hard to read - maybe we could simplify things by having a
"all_histograms" list that includes everything and verify only the expected ones
change (rather than listed all the unaffected ones for each test?).

+    "Blink.UseCounter.Extensions.Features";
 
 const char* const kSVGFeaturesHistogramName =
     "Blink.UseCounter.SVGImage.Features";
 const char* const kSVGCSSHistogramName =
     "Blink.UseCounter.SVGImage.CSSProperties";
 const char* const kSVGAnimatedCSSHistogramName =
     "Blink.UseCounter.SVGImage.AnimatedCSSProperties";
 
 const char* const kLegacyFeaturesHistogramName = "WebCore.FeatureObserver";
 const char* const kLegacyCSSHistogramName =
@@ skipping 202 matching lines @@
       },
       [&](CSSPropertyID property) { use_counter.CountAnimatedCSS(property); },
       [](CSSPropertyID property) -> int {
         return UseCounter::MapCSSPropertyIdToCSSSampleIdForHistogram(property);
       },
       [&](KURL kurl) { use_counter.DidCommitLoad(kurl); }, "about:blank",
       // In practice SVGs always appear to be loaded with an about:blank URL
       1 /* page visit bucket */);
 }
 
+TEST(UseCounterTest, RecordingExtensions) {
+  UseCounter use_counter(UseCounter::kExtensionContext);
+  HistogramBasicTest<UseCounter::Feature>(
+      kExtensionFeaturesHistogramName, kLegacyFeaturesHistogramName,
+      {kSVGFeaturesHistogramName, kFeaturesHistogramName}, UseCounter::kFetch,
+      UseCounter::kFetchBodyStream,
+      [&](UseCounter::Feature feature) -> bool {
+        return use_counter.HasRecordedMeasurement(feature);
+      },
+      [&](UseCounter::Feature feature) {
+        use_counter.RecordMeasurement(feature);
+      },
+      [](UseCounter::Feature feature) -> int { return feature; },
+      [&](KURL kurl) { use_counter.DidCommitLoad(kurl); },
+      "chrome-extension://dummysite", UseCounter::kPageVisits);
+}
+
 // Failing on Android: crbug.com/667913
 #if OS(ANDROID)
 #define MAYBE_InspectorDisablesMeasurement DISABLED_InspectorDisablesMeasurement
 #else
 #define MAYBE_InspectorDisablesMeasurement InspectorDisablesMeasurement
 #endif
 TEST(UseCounterTest, MAYBE_InspectorDisablesMeasurement) {
   UseCounter use_counter;
   HistogramTester histogram_tester;
 
@@ skipping 193 matching lines @@
 
   deprecation_.UnmuteForInspector();
   Deprecation::WarnOnDeprecatedProperties(GetFrame(), property);
   // TODO: use the actually deprecated property to get a deprecation message.
   EXPECT_FALSE(deprecation_.IsSuppressed(property));
   Deprecation::CountDeprecation(GetFrame(), feature);
   EXPECT_TRUE(use_counter_.HasRecordedMeasurement(feature));
 }
 
 }  // namespace blink